fix(example): Calendar Event was not handling relationships correctly #29868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
rjvelazco,
KevinDavilaDotCMS,
oidacra,
nicobytes,
hmoreras and
valentinogiardino
KevinDavilaDotCMS
approved these changes
Sep 4, 2024
valentinogiardino
approved these changes
Sep 4, 2024
zJaaal
deleted the
29768-uve-nextjs-example-breaks-when-adding-event-content
branch
dsolistorres
pushed a commit
that referenced
this pull request
Sep 18, 2024
…#29868) ## Proposed Changes * Add extra logic to avoid access to `undefined` on NextJS and [Astro Example](#29665) ### Note Angular does not have this problem, because Calendar Event is not implemented in the Angular Example ## Screenshots ### NextJS https://github.com/user-attachments/assets/73999bf0-a4a3-4f4a-98e3-272b94552797 ### Astro https://github.com/user-attachments/assets/09881f0b-e322-41bf-8bf2-f0c49aac9a51 ### Angular (No changes) https://github.com/user-attachments/assets/2166c975-68a5-43ca-b701-28b7157f842e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
undefinedon NextJS and Astro ExampleNote
Angular does not have this problem, because Calendar Event is not implemented in the Angular Example
Screenshots
NextJS
Screen.Recording.2024-09-04.at.1.51.10.PM.mov
Astro
Screen.Recording.2024-09-04.at.2.02.39.PM.mov
Angular (No changes)
Screen.Recording.2024-09-04.at.1.53.41.PM.mov
This PR fixes: #29768