Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(old-edit-content): Update Binary Field on save #29540

Merged
merged 7 commits into from
Aug 13, 2024
Merged

chore(old-edit-content): Update Binary Field on save #29540

merged 7 commits into from
Aug 13, 2024

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Aug 12, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Reuse init function of Binary Field on JSP to set Inputs on save

Screenshots

Screen.Recording.2024-08-12.at.2.54.45.PM.mov

This PR fixes: #28337

@zJaaal zJaaal linked an issue Aug 12, 2024 that may be closed by this pull request
Binary Field: Information of assets needs be refreshed after any change #28337
Closed
@zJaaal zJaaal requested a review from nollymar August 12, 2024 19:27
@zJaaal zJaaal added this pull request to the merge queue Aug 13, 2024
@zJaaal zJaaal removed this pull request from the merge queue due to a manual request Aug 13, 2024
@zJaaal zJaaal requested a review from rjvelazco August 13, 2024 18:38
@zJaaal zJaaal enabled auto-merge August 13, 2024 18:59
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zJaaal zJaaal added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 761ef08 Aug 13, 2024
30 checks passed
@zJaaal zJaaal deleted the 28337-binary-field-information-of-assets-needs-be-refreshed-after-any-change branch August 13, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjvelazco rjvelazco rjvelazco approved these changes

@oidacra oidacra oidacra approved these changes

@fmontes fmontes fmontes approved these changes

@nicobytes nicobytes Awaiting requested review from nicobytes

@hmoreras hmoreras Awaiting requested review from hmoreras

@valentinogiardino valentinogiardino Awaiting requested review from valentinogiardino

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

@nollymar nollymar Awaiting requested review from nollymar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary Field: Information of assets needs be refreshed after any change
5 participants
@zJaaal @fmontes @oidacra @nollymar @rjvelazco