Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Field: Information of assets needs be refreshed after any change #28337

Closed
bryanboza opened this issue Apr 23, 2024 · 8 comments · Fixed by #29540, #29603 or #29675
Closed

Binary Field: Information of assets needs be refreshed after any change #28337

bryanboza opened this issue Apr 23, 2024 · 8 comments · Fixed by #29540, #29603 or #29675

Comments

@bryanboza
Copy link
Member

Related to #28115

We are not refreshing the asset information after you do some change and publish it, you need to close the modal and reopen to see the changes.
Attached a video explaining the problem:

Screen.Recording.2024-04-23.at.11.50.46.AM.mov

Basically we need to update the generating information every time you click on this button.

Originally posted by @bryanboza in #28115 (comment)

@fmontes fmontes changed the title Information of assets needs be refreshed after any change Binary Field: Information of assets needs be refreshed after any change May 2, 2024
@fmontes fmontes moved this from New to Gardening Day Backlog in dotCMS - Product Planning May 9, 2024
@fmontes fmontes moved this from Gardening Day Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jul 9, 2024
@nollymar nollymar moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Jul 11, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 12, 2024
@zJaaal zJaaal linked a pull request Aug 12, 2024 that will close this issue
@zJaaal
Copy link
Contributor

zJaaal commented Aug 12, 2024

The scope of this ticket covers the JSP side of the Binary Field. We need to make sure this already works on the Angular side otherwise, we should create a ticket for it.

cc: @nollymar @fmontes

@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Aug 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 13, 2024
@zJaaal zJaaal reopened this Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 13, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Aug 13, 2024
@zJaaal zJaaal removed their assignment Aug 13, 2024
@rjvelazco rjvelazco self-assigned this Aug 15, 2024
@rjvelazco rjvelazco moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 15, 2024
@rjvelazco
Copy link
Contributor

rjvelazco commented Aug 15, 2024

Failed Internal QA

  • Tested on docker image: [dotcms/dotcms:trunk_b535434]

Video

iqa-28337-binary-field-information-of-assets-needs-be-refreshed-after-any-change.mov

@rjvelazco
Copy link
Contributor

rjvelazco commented Aug 19, 2024

Failed Internal QA

  • Tested on docker image: [dotcms/dotcms:trunk_ c8f8051]
  • Server dotCMS QA Master

Steps to Reproduce

  1. Go to Content Search
  2. Create a new File contentlet
  3. Add an image
  4. Publish
  5. See the error. The image disappears

Video

iqa-28337-binary-field-information-of-assets-needs-be-refreshed-after-any-change-content-disappears.mov

@rjvelazco rjvelazco moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 19, 2024
@rjvelazco rjvelazco removed their assignment Aug 19, 2024
@zJaaal zJaaal self-assigned this Aug 19, 2024
@fmontes
Copy link
Member

fmontes commented Aug 20, 2024

This is an edge case difficult to solve with the current implementation of JSP edit content. We don't need to fix this in the old content editor; we can make sure it works in the new content editor. We can close this one, but make sure that @dsilvam and @john-thomas-dotcms know about this so it doesn't happen in the new editor.

@zJaaal zJaaal linked a pull request Aug 20, 2024 that will close this issue
@zJaaal
Copy link
Contributor

zJaaal commented Aug 20, 2024

I have sent a revert to leave it as was

@zJaaal
Copy link
Contributor

zJaaal commented Aug 21, 2024

Note to QA

After what we decided, just be sure it works as it was before.

@zJaaal zJaaal reopened this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 21, 2024
@zJaaal zJaaal removed their assignment Aug 21, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Aug 21, 2024
@valentinogiardino valentinogiardino moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Aug 25, 2024
@valentinogiardino
Copy link
Contributor

IQA Passed Internal

  • Tested on docker image: [dotcms/dotcms:trunk_ 36f72e4]
  • After the rollback, it is working as before
iqa-binary-field-assets-info.mov

@github-project-automation github-project-automation bot moved this from QA - Backlog to Internal QA in dotCMS - Product Planning Aug 25, 2024
@valentinogiardino valentinogiardino moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Aug 25, 2024
@bryanboza
Copy link
Member Author

We don't have a fix here, everything still working in the same way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment