#28813: Moving OpenAI Model paramenters to dotAI App configuration #29236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdotcms
reviewed
Jul 23, 2024
jdotcms
reviewed
Jul 23, 2024
victoralfaro-dotcms
force-pushed
the
issue-28813-dotai-model-to-app-param
branch
3 times, most recently
from
f215d0b to
feee80a
Compare
victoralfaro-dotcms
force-pushed
the
issue-28813-dotai-model-to-app-param
branch
from
feee80a to
29e7807
Compare
dsilvam
reviewed
Jul 30, 2024
dsilvam
reviewed
Jul 30, 2024
|
Please include description for the PR @victoralfaro-dotcms |
jcastro-dotcms
approved these changes
Jul 30, 2024
|
dsilvam
reviewed
Jul 30, 2024
dotcms-integration/src/test/java/com/dotcms/http/CircuitBreakerUrlTest.java
Show resolved
Hide resolved
dsilvam
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing hardcoded OpenAI models at enum class OpenAIModel. Instead they are now part of the
dotAI.ymlapplication descriptor so the user can be the one who configures them not only one but multiple models fortext,imageandembeddings.The way to specify more than one is to provide a comma delimited list in the new dotAI App params.
Sometimes we accept a model to use in the payload of our AI endpoints, for this matter we will validate that model and if it's invalid we will throw an exception.
When is not present in the payload, then our backend will inject the current model.
Which leads us to the question: How will the current model be determined?
This is part of the work defined for #29284 (model fallback)
This PR fixes: #28813