-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate OpenAI model parameters to dotAI App params #29281
Relocate OpenAI model parameters to dotAI App params #29281
Comments
QA Comment List of test cases created for this card. #29567 (comment) |
Note from QA: These changes could affect part of the AI functionality, which is why we need to split the work for the QA regression. Based on this, we estimate that a quick regression is needed in some key identified areas. @josemejias11 has already shared a CSV file with the tests that need to be covered by the team. Please coordinate the distribution, @dsilvam . Additionally, we will focus on the regression of the sub-actions to ensure everything continues working normally and that nothing was affected by the changes. Once all the mentioned work is done, we'll be ready to release. Thanks for your help, team! |
…reak the tests when any of AI API url or AI API key are missing. Clean the default values for model names and max tokens are now required.
…d 'type' instead of just a list os strings
…reak the tests when any of AI API url or AI API key are missing. Clean the default values for model names and max tokens are now required.
…d 'type' instead of just a list os strings
…reak the tests when any of AI API url or AI API key are missing. Clean the default values for model names and max tokens are now required.
…d 'type' instead of just a list os strings. Throwing exceptions when AppConfig.isEnabled() is false to break the tests when any of AI API url or AI API key are missing. Clean the default values for model names. Added better logging at key places when interacting with OpenAI provider. Tests were added/updated. noop
…d 'type' instead of just a list os strings. Throwing exceptions when AppConfig.isEnabled() is false to break the tests when any of AI API url or AI API key are missing. Clean the default values for model names. Added better logging at key places when interacting with OpenAI provider. Tests were added/updated.
Returning available models as object that includes 'name' and 'type' instead of just a list os strings. Throwing exceptions when AppConfig.isEnabled() is false to break the tests when any of AI API url or AI API key are missing. Clean the default values for model names. Added better logging at key places when interacting with OpenAI provider. Tests were added/updated.
IQA Findings:
Screenshare.-.2024-08-16.3_35_54.PM.mp4
|
Approved: Tested on trunk_bffd903, Docker, macOS 14.5, FF v126.0.1 |
Parent Issue
#28813
User Story
As a Java developer, I want to be able to relocate the hardcoded OpenAI models in our code to the dotAI application, specifically as parameters for each field that conform a model: model names, tokens per minute, API per minute, max number of tokens, and if it's a completion model flag. The changes will include:
dotAI.yml
Application descriptor filemodels
endpoint.Consider that
Model Names
field is actually a comma delimited list of models.This will need to happen for both text and image models and changes in the
dotAI.yml
file will result in having UI changes in the Apps portlet that QA will see when testing.Acceptance Criteria
dotAI.yml
Application descriptor file includes the fields: model names, tokens per minute, API per minute, max number of tokens, and completion model flag.dotAI.yml
instead of the code.dotAI.yml
.dotCMS Version
master
Proposed Objective
Core Features
Proposed Priority
Priority 2 - Important
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
to_define
Assumptions & Initiation Needs
dotAI.yml
format and structure are predefined and agreed upon.Quality Assurance Notes & Workarounds
dotAI.yml
configurations are correctly read and applied in various scenarios.gpt-3.5-turbo-16k
,dall-e-3
andtext-embedding-ada-002
respectively. Add the following at theAuto Index Content Config
field:Blog
content, go to theSEO
tab and verify that AI content is generated by hitting the button for SEO metadata fieldDev Tools
->dotAI
, atManage Embeddings/Indexes
tab, atIndex Name
specify:aiBlog
, atContent to Index by Query:
field specify:+contentType:blog
and build index based on that. Verify that there are index created/updated.The text was updated successfully, but these errors were encountered: