chore(edit-content): add validation to current path #28933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired-then-we-do-not-allowshow-system_host
…we-do-not-allowshow-system_host' into 28925-if-no-value-we-should-default-to-current-selected-host
…rent-selected-host
…-host' of github.com:dotCMS/core into 28925-if-no-value-we-should-default-to-current-selected-host
zJaaal
requested changes
Jun 19, 2024
core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Jun 19, 2024
zJaaal
changed the title
fmontes
approved these changes
Jun 19, 2024
|
nicobytes
deleted the
28925-if-no-value-we-should-default-to-current-selected-host
branch
oidacra
pushed a commit
that referenced
this pull request
Jun 26, 2024
If the siteFolder field is required, it defaults to current host If the siteFolder field is not required, it defaults to system host ### Proposed Changes * Add empty path validation * Call currentSite() if required * Select 'System Host' if not required ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable) ### Screenshots If the siteFolder field is not required, it defaults to system host.  If the siteFolder field is required, it defaults to current host 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the siteFolder field is required, it defaults to current host
If the siteFolder field is not required, it defaults to system host
Proposed Changes
Checklist
Screenshots
If the siteFolder field is not required, it defaults to system host.
If the siteFolder field is required, it defaults to current host
This PR fixes: #28925