Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no value, we should default to current selected host #28925

Closed
Tracked by #28494
nicobytes opened this issue Jun 18, 2024 · 3 comments · Fixed by #28933 or #28946
Closed
Tracked by #28494

If no value, we should default to current selected host #28925

nicobytes opened this issue Jun 18, 2024 · 3 comments · Fixed by #28933 or #28946

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Jun 18, 2024

Parent Issue => #28494

Screenshots

If the siteFolder field is not required, it defaults to system host.

Screenshot 2024-06-19 at 10 01 36 AM

If the siteFolder field is required, it defaults to current host

Screenshot 2024-06-19 at 10 03 18 AM

@dsilvam
Copy link
Contributor

dsilvam commented Jun 19, 2024

Failed IQA:

  1. Marked siteFolder as required
  2. Opened new content dialog. It correctly had pre-selected the current site.
  3. Hit save

If fails with the following error

https://gist.github.com/dsilvam/dda940bc803b7b051ca10ee5b2eef116
Image

@nicobytes nicobytes reopened this Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jun 19, 2024
@nicobytes nicobytes removed the Merged label Jun 19, 2024
@nicobytes nicobytes moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jun 19, 2024
@nicobytes nicobytes linked a pull request Jun 19, 2024 that will close this issue
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Jun 19, 2024
@nicobytes nicobytes moved this from In Review to Internal QA in dotCMS - Product Planning Jun 19, 2024
@dsilvam dsilvam assigned dsilvam and unassigned nicobytes Jun 20, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 20, 2024

Passed Internal QA:

  • Defaulting to System Host when the siteFolder field is not required
  • Defaulting to Current Host when the siteFolder field is required.

Being able to save/publish the content on both cases.

@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Jun 20, 2024
@dsilvam dsilvam moved this from Done to QA - Backlog in dotCMS - Product Planning Jun 20, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jun 20, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_6d3ea16, Docker, macOS 14.5, FF v126.0.1
Screenshot 2024-06-21 at 1 05 05 PM

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment