#23603 : Allow users to write code when creating a file - PR2 #24267

jcastro-dotcms · 2023-03-03T14:21:15Z

Proposed Changes

Allow users to write code when creating a file. A new method was added to the Temp File API and the Temp File Endpoint to allow back-end users to "upsert" a temporary file.
The Text Area field is displayed when a new File Asset is created. This way, Users can either upload a binary file, or start typing its contents in the Text Area field.
The initial mechanism used to create the content of the File Asset is the same one used when we're editing an existing text File Asset.

github-actions · 2023-03-03T14:41:08Z

Unit Tests Report

1 422 tests ±0 1 412 ✔️ ±0 3m 51s ⏱️ -3s
  140 suites ±0     10 💤 ±0
  140 files ±0       0 ❌ ±0

Results for commit 94b7d3a. ± Comparison against base commit 4d158c9.

♻️ This comment has been updated with latest results.

…ode-when-creating-file-pr2

github-actions · 2023-03-03T16:38:30Z

Postman Tests Report

    65 files ±0 1 407 suites +3 3h 40m 24s ⏱️ -38s
  629 tests +5   625 ✔️ +4 0 💤 ±0 4 ❌ +1
2 341 runs +5 2 335 ✔️ +4 0 💤 ±0 6 ❌ +1

For more details on these failures, see this check.

Results for commit 94b7d3a. ± Comparison against base commit 4d158c9.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.

TempApi ‑ File name check

TempApi ‑ Checking file names and operation status code
TempApi ‑ New Temporary File ID must NOT match the previous one
TempApi ‑ Non-Existing Test Temporary File creation HTTP Status must be successful
TempApi ‑ Temporary File ID must be the same
TempApi ‑ Test Temporary File creation HTTP Status must be successful
TempApi ‑ Test Temporary File update HTTP Status must be successful

♻️ This comment has been updated with latest results.

github-actions · 2023-03-03T17:12:18Z

Integration Tests [postgres] Report

  409 files ±0   409 suites ±0 1h 27m 9s ⏱️ - 10m 6s
3 905 tests ±0 3 879 ✔️ ±0 23 💤 ±0 3 ❌ ±0
3 926 runs ±0 3 900 ✔️ ±0 23 💤 ±0 3 ❌ ±0

For more details on these failures, see this check.

Results for commit 94b7d3a. ± Comparison against base commit 4d158c9.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-03T18:51:11Z

Integration Tests [mssql] Report

0 tests ±0 0 ✔️ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 94b7d3a. ± Comparison against base commit 4d158c9.

♻️ This comment has been updated with latest results.

…ode-when-creating-file-pr2

fabrizzio-dotCMS · 2023-03-10T17:10:16Z

dotCMS/src/main/java/com/dotcms/rest/api/v1/temp/TempFileAPI.java

+   * @param tempFileId The ID of the Temporary File.
+   *
+   * @return The {@link DotTempFile} matching the specified ID.
+   */
  private Optional<DotTempFile> getTempFile(final String tempFileId) {

    if (tempFileId == null || !tempFileId.startsWith(TEMP_RESOURCE_PREFIX)) {


manuelrojas · 2023-03-10T17:09:20Z

dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_file_asset_text_inc.jsp

+					tempFileId = jsonData.tempFiles[0].id;
+					const elements = document.getElementsByName("<%= field.getFieldContentlet() %>");
+					for (let i = 0; i < elements.length; i++) {
+						if (elements[i].tagName.toLowerCase() == "input") {


Suggested change

if (elements[i].tagName.toLowerCase() == "input") {

if (elements[i].tagName.toLowerCase() === "input") {

manuelrojas · 2023-03-10T17:10:21Z

dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_file_asset_text_inc.jsp

+					const jsonData = JSON.parse(xhr.response);
+					tempFileId = jsonData.tempFiles[0].id;
+					const elements = document.getElementsByName("<%= field.getFieldContentlet() %>");
+					for (let i = 0; i < elements.length; i++) {


Suggested change

for (let i = 0; i < elements.length; i++) {

for (const element of elements) {

manuelrojas · 2023-03-10T17:11:35Z

dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_file_asset_text_inc.jsp

+			FileAssetAjax.saveFileText(contentletInode.value, text, '<%=field.getVelocityVarName()%>', {
+				async: false,
+				callback: function (data) {
+					console.log("savedText");


Do we need these logs?

Suggested change

console.log("savedText");

console.warn("savedText");

Removing code.

manuelrojas · 2023-03-10T17:13:12Z

dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_file_asset_text_inc.jsp

+
+				xhr.addEventListener("readystatechange", function() {
+					if(this.readyState === 4) {
+						console.log(this.responseText);


Do we need these logs?

Suggested change

console.log(this.responseText);

console.warn(this.responseText);

Removing code.

dotcms-sonarqube · 2023-03-10T17:49:28Z

SonarQube Quality Gate

0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

… PR2 (#24267)" This reverts commit b6f0095.

… PR2 (#24267)" (#24576) This reverts commit b6f0095.

… PR2 (#24267)" This reverts commit b6f0095.

jcastro-dotcms added 8 commits March 2, 2023 10:42

Implementing SonarQube feedback.

289ee7b

#23603 : Allow users to write code when creating a file

ba73c89

Adding more code changes and Postman tests.

f307887

Fixing other Postman Tests.

c96803e

#23603 : Forbid access to Temp File update method for Anonymous Users.

f2c9e9b

Implementing SonarQube feedback.

380d9bd

Implementing SonarQube feedback.

99d0455

#23603 : Creating new branch based on master.

c77114a

jcastro-dotcms linked an issue Mar 3, 2023 that may be closed by this pull request

EC: Allow users to write code when create a file #23603

Closed

Merge remote-tracking branch 'origin/master' into issue-23603-write-c…

9208639

…ode-when-creating-file-pr2

Merge remote-tracking branch 'origin/master' into issue-23603-write-c…

8d78135

…ode-when-creating-file-pr2

jdotcms approved these changes Mar 7, 2023

View reviewed changes

jcastro-dotcms added 3 commits March 8, 2023 09:34

Merge remote-tracking branch 'origin/master' into issue-23603-write-c…

62dee26

…ode-when-creating-file-pr2

Merge remote-tracking branch 'origin/master' into issue-23603-write-c…

5aeeef7

…ode-when-creating-file-pr2

Merge remote-tracking branch 'origin/master' into issue-23603-write-c…

94b7d3a

…ode-when-creating-file-pr2

fabrizzio-dotCMS approved these changes Mar 10, 2023

View reviewed changes

manuelrojas reviewed Mar 10, 2023

View reviewed changes

Implementing JS feedback from Manuel Rojas.

0163b9d

manuelrojas approved these changes Mar 10, 2023

View reviewed changes

Implementing more JS feedback from Manuel Rojas.

75535d4

manuelrojas approved these changes Mar 10, 2023

View reviewed changes

fmontes merged commit b6f0095 into master Mar 10, 2023

fmontes deleted the issue-23603-write-code-when-creating-file-pr2 branch March 10, 2023 17:45

fmontes mentioned this pull request Mar 13, 2023

Implement the UI for create files using code #24362

Closed

3 tasks

dsilvam added a commit that referenced this pull request Apr 6, 2023

Revert "Fix #23603 : Allow users to write code when creating a file -…

79db6d8

… PR2 (#24267)" This reverts commit b6f0095.

dsilvam added a commit that referenced this pull request Apr 6, 2023

Revert "Fix #23603 : Allow users to write code when creating a file -…

03732ac

… PR2 (#24267)" (#24576) This reverts commit b6f0095.

wezell added a commit that referenced this pull request Apr 6, 2023

Revert "Fix #23603 : Allow users to write code when creating a file -…

f1ffd65

… PR2 (#24267)" This reverts commit b6f0095.

rjvelazco mentioned this pull request Sep 11, 2023

Edit Contentlet: Allow User Write Code #26045

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#23603 : Allow users to write code when creating a file - PR2 #24267

#23603 : Allow users to write code when creating a file - PR2 #24267

jcastro-dotcms commented Mar 3, 2023

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

fabrizzio-dotCMS Mar 10, 2023

manuelrojas Mar 10, 2023

jcastro-dotcms Mar 10, 2023

manuelrojas Mar 10, 2023

jcastro-dotcms Mar 10, 2023

manuelrojas Mar 10, 2023

jcastro-dotcms Mar 10, 2023

manuelrojas Mar 10, 2023

jcastro-dotcms Mar 10, 2023

dotcms-sonarqube bot commented Mar 10, 2023

	if (elements[i].tagName.toLowerCase() == "input") {
	if (elements[i].tagName.toLowerCase() === "input") {

	for (let i = 0; i < elements.length; i++) {
	for (const element of elements) {

	console.log(this.responseText);
	console.warn(this.responseText);

#23603 : Allow users to write code when creating a file - PR2 #24267

#23603 : Allow users to write code when creating a file - PR2 #24267

Conversation

jcastro-dotcms commented Mar 3, 2023

Proposed Changes

github-actions bot commented Mar 3, 2023 • edited Loading

Unit Tests Report

github-actions bot commented Mar 3, 2023 • edited Loading

Postman Tests Report

github-actions bot commented Mar 3, 2023 • edited Loading

Integration Tests [postgres] Report

github-actions bot commented Mar 3, 2023 • edited Loading

Integration Tests [mssql] Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotcms-sonarqube bot commented Mar 10, 2023

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading