Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC: Allow users to write code when create a file #23603

Closed
Tracked by #23599
fmontes opened this issue Dec 16, 2022 · 9 comments · Fixed by #24267
Closed
Tracked by #23599

EC: Allow users to write code when create a file #23603

fmontes opened this issue Dec 16, 2022 · 9 comments · Fixed by #24267

Comments

@fmontes
Copy link
Member

fmontes commented Dec 16, 2022

Is your feature request related to a problem? Please describe.

As a user, I want to be able to create code file easily.

VTL files are widely used in dotCMS and the only way to create one is created one with a code editor and then upload it.

Describe the solution you'd like

  1. When create a file, add a new code field, so users can write code and save the file.

  2. Keep the functionality of the file input field, so the user can upload files from the file system.

Design

Use a code editor for the code. We'll have another issue for the final UI.

Acceptance criteria

  • Allow user to write code to create a file

  • Allow user to browse files

@damen-dotcms damen-dotcms moved this from New to Next in dotCMS - Product Planning Jan 26, 2023
@damen-dotcms damen-dotcms moved this from Next to Future in dotCMS - Product Planning Jan 26, 2023
@damen-dotcms damen-dotcms moved this from Future to Next Sprint in dotCMS - Product Planning Feb 1, 2023
@jcastro-dotcms jcastro-dotcms self-assigned this Feb 14, 2023
@fmontes fmontes moved this from Next 1-3 Sprints to In Review in dotCMS - Product Planning Feb 24, 2023
fmontes pushed a commit that referenced this issue Mar 10, 2023
…4267)

* Implementing SonarQube feedback.

* #23603 : Allow users to write code when creating a file

* Adding more code changes and Postman tests.

* Fixing other Postman Tests.

* #23603 : Forbid access to Temp File update method for Anonymous Users.

* Implementing SonarQube feedback.

* Implementing SonarQube feedback.

* #23603 : Creating new branch based on master.

* Implementing JS feedback from Manuel Rojas.

* Implementing more JS feedback from Manuel Rojas.
@fmontes
Copy link
Member Author

fmontes commented Mar 10, 2023

There is a part two of this to do the UI

@fmontes fmontes moved this from In Review to Internal QA in dotCMS - Product Planning Mar 13, 2023
@fmontes fmontes self-assigned this Mar 30, 2023
@rjvelazco rjvelazco moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Mar 31, 2023
dsilvam added a commit that referenced this issue Apr 6, 2023
dsilvam added a commit that referenced this issue Apr 6, 2023
@dsilvam
Copy link
Contributor

dsilvam commented Apr 6, 2023

Reverting from 23.05: #24576

wezell added a commit that referenced this issue Apr 6, 2023
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning May 5, 2023
@josemejias11 josemejias11 moved this from QA - In Progress to QA - Backlog in dotCMS - Product Planning May 16, 2023
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning May 18, 2023
@bryanboza
Copy link
Member

bryanboza commented May 23, 2023

Reading the comments, I think we rollback this change, then we need to test something here or we can close this card? If we don't need to test anything please add the: "QA not needed" label

@wezell @fmontes

@fmontes
Copy link
Member Author

fmontes commented May 30, 2023

I'm sorry this should not be in QA, the was rollbacked a while ago.

@fmontes fmontes moved this from QA - In Progress to Current Sprint Backlog in dotCMS - Product Planning May 30, 2023
@fmontes fmontes moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jun 5, 2023
@fmontes
Copy link
Member Author

fmontes commented Jul 10, 2023

@jdotcms Can you provide the endpoint to use for the binary or text?

@jdotcms
Copy link
Contributor

jdotcms commented Jul 10, 2023

curl --location --request PUT 'http://localhost:8080/api/v1/workflow/actions/default/fire/PUBLISH' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW5AZG90Y21zLmNvbTphZG1pbg==' \
--header 'Cookie: access_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJqdGkiOiI0NjE3NmUxMi02YzJkLTQwNmMtYjcyNC00ZGZhYzQ1NjI1MTciLCJ4bW9kIjoxNjg3OTAwOTU4NzMxLCJzdWIiOiJkb3RjbXMub3JnLjEiLCJpYXQiOjE2ODc5MDA5NTgsImlzcyI6IjU4N2ZhMTAwMWUiLCJleHAiOjE2ODc5ODczNTh9.WDE1o3harTOtNtBWdWNkFUPVwY4P9G2u9pd55nPJlW0' \
--data '{
    "contentlet": {
        "hostFolder":"default",
        "title": "greatings.txt",
        "fileName": "greatings.txt",
        "fileAsset": {
            "fileName": "greatings.txt",
           "content": "Hello dotCMS"
         },
        "contentType": "FileAsset"
    }
}'

@rjvelazco rjvelazco moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Aug 3, 2023
@fmontes fmontes reopened this Aug 11, 2023
@rjvelazco rjvelazco moved this from In Progress to Current Sprint Backlog in dotCMS - Product Planning Aug 14, 2023
@fmontes fmontes moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Sep 26, 2023
@fmontes
Copy link
Member Author

fmontes commented Sep 26, 2023

Closing in favor of

#26219
#26048

@fmontes fmontes closed this as completed Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Next 1-3 Sprints to Done in dotCMS - Product Planning Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants