Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23603 : Allow users to write code when creating a file #24181

Closed

Conversation

jcastro-dotcms
Copy link
Contributor

@jcastro-dotcms jcastro-dotcms commented Feb 22, 2023

Proposed Changes

  • Allow users to write code when creating a file. A new method was added to the Temp File API and the Temp File Endpoint to allow back-end users to "upsert" a temporary file.
  • The Text Area field is displayed when a new File Asset is created. This way, Users can either upload a binary file, or start typing its contents in the Text Area field.
  • The initial mechanism used to create the content of the File Asset is the same one used when we're editing an existing text File Asset.

@jcastro-dotcms jcastro-dotcms linked an issue Feb 22, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 22, 2023

Postman Tests Report

     65 files  ±0  1 406 suites  +3   3h 15m 2s ⏱️ - 3m 0s
   630 tests +5     628 ✔️ +5  0 💤 ±0  2 ±0 
2 340 runs  +5  2 336 ✔️ +5  0 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit 5649c37. ± Comparison against base commit feeb5c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Unit Tests Report

1 418 tests  ±0   1 408 ✔️ ±0   3m 56s ⏱️ ±0s
   140 suites ±0        10 💤 ±0 
   140 files   ±0          0 ±0 

Results for commit 5649c37. ± Comparison against base commit feeb5c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Integration Tests [postgres] Report

   409 files  ±0     409 suites  ±0   1h 8m 19s ⏱️ -55s
3 900 tests ±0  3 875 ✔️ ±0  23 💤 ±0  2 ±0 
3 921 runs  ±0  3 896 ✔️ ±0  23 💤 ±0  2 ±0 

For more details on these failures, see this check.

Results for commit 5649c37. ± Comparison against base commit feeb5c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Integration Tests [mssql] Report

   408 files  +   408     408 suites  +408   2h 34m 26s ⏱️ + 2h 34m 26s
3 895 tests +3 895  3 856 ✔️ +3 856  23 💤 +23  16 +16 
3 916 runs  +3 916  3 877 ✔️ +3 877  23 💤 +23  16 +16 

For more details on these failures, see this check.

Results for commit 5649c37. ± Comparison against base commit feeb5c5.

♻️ This comment has been updated with latest results.

@jcastro-dotcms jcastro-dotcms marked this pull request as ready for review February 24, 2023 16:01
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jcastro-dotcms jcastro-dotcms changed the base branch from release-23.03 to master March 2, 2023 16:36
@jcastro-dotcms jcastro-dotcms changed the base branch from master to release-23.03 March 2, 2023 16:37
@jcastro-dotcms
Copy link
Contributor Author

Closing this PR as it will not be included in release-23.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants