Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVE: Ask user to create page if the language doesn't exist #28958

Closed
4 tasks done
fmontes opened this issue Jun 20, 2024 · 5 comments · Fixed by #29076
Closed
4 tasks done

UVE: Ask user to create page if the language doesn't exist #28958

fmontes opened this issue Jun 20, 2024 · 5 comments · Fixed by #29076

Comments

@fmontes
Copy link
Member

fmontes commented Jun 20, 2024

As a user, I want to be notified when selecting a language in the Universal Visual Editor that does not have a page version, so I can decide whether to create a new version in that language.

Acceptance Criteria

Preview Give feedback

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.:

Assumptions & Initiation Needs

The user has access to the Universal Visual Editor and is trying to select a language without an existing page version.

Quality Assurance Notes & Workarounds

This should work exactly as the old page editor.

@fmontes fmontes moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Jun 20, 2024
@zJaaal zJaaal self-assigned this Jun 28, 2024
@zJaaal zJaaal moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Jun 28, 2024
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Jul 2, 2024
@zJaaal zJaaal moved this from In Review to In Progress in dotCMS - Product Planning Jul 2, 2024
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Jul 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 4, 2024
#29076)

## Proposed changes

- Fetch languages for the current page and check whether or not it has a
translation. If it has one we let the user pass, if not we prompt to
know if the user wants to create a page or not.

### Screenshot


https://github.com/dotCMS/core/assets/63567962/7d20eb2d-e747-4ebc-977e-1fb765d704ed
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Jul 4, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Jul 4, 2024

Note to QA

We have this ticket present for the templates

We should be sure that the dialog to decide whether or not to translate a page works as expected, any error with the creation of it should be another ticket since this implementation is the same as the old editor and the only thing that changed is that in the UVE we should not be able to open a page without translation before seeing this dialog.

@zJaaal zJaaal reopened this Jul 4, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jul 4, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jul 4, 2024
@zJaaal zJaaal removed their assignment Jul 4, 2024
@rjvelazco rjvelazco self-assigned this Jul 8, 2024
@rjvelazco
Copy link
Contributor

rjvelazco commented Jul 8, 2024

Failed Internal QA

  • Tested on docker: [dotcms/trunk_ e2e9497]

Steps to reproduce

  1. Create a Page in English.
  2. Go to theedit page portlet.
  3. Add a content.
  4. Go to the language dropdown.
  5. Click Español and create the page.
  6. See the error.

NOTE: In the old editor, we create the page and maintain all the content to it

Video

issue-28958-uve-ask-user-to-create-page-if-the-language-doesnt-exist.11.33.18.AM.mov

@rjvelazco rjvelazco moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jul 8, 2024
@rjvelazco rjvelazco removed their assignment Jul 8, 2024
@rjvelazco
Copy link
Contributor

@nollymar @fmontes Should we keep this behavior or do we want the old editor behavior?

I think the correct behavior is "do not copy" the page but I added the label QA: Failed Internal because of the requirements (It should work as the old editor).

@rjvelazco
Copy link
Contributor

rjvelazco commented Jul 8, 2024

Passed Internal QA

  • Tested on docker: [dotcms/trunk_e2e9497]

The new editor is working as expected [Like the old editor]. demo is outdated

Video - Old Editor Behavior

iqa.mov

@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jul 8, 2024
@rjvelazco rjvelazco moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jul 8, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jul 8, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_59c1326, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment