Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] adding test case for case-insensitive key lookups #2640

Merged
merged 3 commits into from
Aug 26, 2024
Merged

[no-release-notes] adding test case for case-insensitive key lookups #2640

merged 3 commits into from
Aug 26, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Aug 26, 2024

No description provided.

@jycor jycor mentioned this pull request Aug 26, 2024
Merged
max-hoffman
max-hoffman approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe do this as a join_op_test.go instead, so that we can run this check through each execution operator. You could optionally use a simplified schema/invert the capitalization to do the same check.

@jycor jycor merged commit 024a764 into main Aug 26, 2024
7 of 8 checks passed
@jycor jycor deleted the james/case-test branch August 26, 2024 21:37
@BrewTestBot BrewTestBot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman