Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case insensitive column match in kv iter #8296

Merged
merged 4 commits into from
Aug 26, 2024
Merged

fix case insensitive column match in kv iter #8296

merged 4 commits into from
Aug 26, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Aug 26, 2024

When building the keyLookupMapper for the special prolly tree kvIter, we match column names by exact casing. This leads to incorrect lookup indexes.

The fix was to use lowercase when matching.

companion pr: dolthub/go-mysql-server#2640

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe move nil check inside valid?

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e77920b ok 5937457
version total_tests
e77920b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
31083ab ok 5937457
version total_tests
31083ab 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
dcfce45 ok 5937457
version total_tests
dcfce45 5937457
correctness_percentage
100.0

@jycor jycor merged commit 849e099 into main Aug 26, 2024
21 checks passed
@jycor jycor deleted the james/casing branch August 26, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants