-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get OverloadType PETSc.vec #157
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d798f9b
Get OverloadType PETSc.vec
Ig-dolci c9b4e82
write and read only petsc vecs
Ig-dolci e45ede4
write and read only petsc vecs
Ig-dolci ccc1c73
Update pyadjoint/overloaded_type.py
Ig-dolci ffb1768
Update pyadjoint/overloaded_type.py
Ig-dolci 6ed08b5
documenting
Ig-dolci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -320,6 +320,28 @@ def _ad_str(self): | |
""" | ||
return str(self) | ||
|
||
def _ad_petsc_vec_read_only(self): | ||
"""This method should be overwritten by types which can return a PETSc Vec. | ||
|
||
The method should implement a routine to return a read only a PETSc Vec object. | ||
|
||
Returns: | ||
PETSc.Vec: A PETSc Vec object containing the data of the overloaded. | ||
|
||
""" | ||
raise NotImplementedError | ||
|
||
def _ad_petsc_vec_write_only(self): | ||
"""This method must be overridden. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done.
Ig-dolci marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
The method should implement a routine to write only a PETSc Vec object. | ||
|
||
Returns: | ||
PETSc.Vec: A PETSc Vec object containing the data of the overloaded. | ||
|
||
""" | ||
raise NotImplementedError | ||
|
||
|
||
class FloatingType(OverloadedType): | ||
def __init__(self, *args, **kwargs): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I consider adding an optional argument like with_halos? Or does it not make sense?