Get OverloadType PETSc.vec #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
reviewed
Jul 8, 2024
dham
reviewed
Jul 8, 2024
pyadjoint/overloaded_type.py
Outdated
| raise NotImplementedError | ||
|
|
||
| def _ad_petsc_vec_write_only(self): | ||
| """This method must be overridden. |
Co-authored-by: David A. Ham <[email protected]>
Ig-dolci
commented
Jul 8, 2024
|
Should document that these are context managers, and also document what is expected on entry/exit (ghost updates? other data consistency updates?). |
Yes. That is an important point. I will study more about the management of Petsc vecs and try to improve the docs. |
Ig-dolci
commented
Jul 9, 2024
| @@ -320,6 +320,42 @@ def _ad_str(self): | |||
| """ | |||
| return str(self) | |||
|
|
|||
| def _ad_petsc_vec_read_only(self): | |||
There was a problem hiding this comment.
Should I consider adding an optional argument like with_halos? Or does it not make sense?
|
This PR is not necessary anymore. OverloadedTypes to copy and update PETSc Vecs are available at the PR 143. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
OverloadTypemethod to get thePETSc.petsc4py.Vecobject.