Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix score if batch_iterator_test doesn't yield same order / size as y #270

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions nolearn/lasagne/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def __init__(

if isinstance(layers, Layer):
layers = _list([layers])

self.layers = layers
self.update = update
self.objective = objective
Expand Down Expand Up @@ -686,20 +686,31 @@ def apply_batch_func(func, Xb, yb=None):
else:
return func(Xb) if yb is None else func(Xb, yb)

def predict_proba(self, X):
def predict_proba(self, X, y=None):
probas = []
for Xb, yb in self.batch_iterator_test(X):
ys = []
for Xb, yb in self.batch_iterator_test(X, y):
probas.append(self.apply_batch_func(self.predict_iter_, Xb))
return np.vstack(probas)
ys.append(yb)
if y is not None:
return np.vstack(probas), np.hstack(ys)
else:
return np.vstack(probas)

def predict(self, X):
def predict(self, X, y=None):
if self.regression:
return self.predict_proba(X)
return self.predict_proba(X, y)
else:
y_pred = np.argmax(self.predict_proba(X), axis=1)
predictions = self.predict_proba(X, y)
if y is not None:
predictions, y_actual = predictions
y_pred = np.argmax(predictions, axis=1)
if self.use_label_encoder:
y_pred = self.enc_.inverse_transform(y_pred)
return y_pred
if y is not None:
return y_pred, y_actual
else:
return y_pred

def get_output(self, layer, X):
if isinstance(layer, basestring):
Expand All @@ -724,7 +735,7 @@ def get_output(self, layer, X):

def score(self, X, y):
score = mean_squared_error if self.regression else accuracy_score
return float(score(self.predict(X), y))
return float(score(*self.predict(X, y)))

def get_all_layers(self):
return self.layers_.values()
Expand Down