Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix score if batch_iterator_test doesn't yield same order / size as y #270

Closed
wants to merge 1 commit into from

Conversation

cancan101
Copy link
Contributor

Closes #269

@BenjaminBossan
Copy link
Collaborator

I believe we should avoid having methods that return different things (single item vs tuple) depending on how you call them.

An alternative could be that we implement a method that transforms X and y, e.g.:

Xt, yt = net.batch_iterator_test.transform(X, y)
score = accuracy_score(y_true, yt)

This would also be useful in case someone needs the transformed X.

@cancan101
Copy link
Contributor Author

This is something that should happen batch wise. What you have will pull all of the "transformed" Xs into memory.

@cancan101
Copy link
Contributor Author

This is not just about transforming the y's (which is important), but also about the batch nature of access to the underlying data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants