Add chinese translation #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chinese translation for CloseAllFrameworkAssembliesCommand
Add and modify Chinese translations in setting options, and add descriptions of some function options
UlyssesWu
reviewed
Jul 9, 2024
Extensions/dnSpy.Debugger/dnSpy.Debugger/Properties/dnSpy.Debugger.Resources.zh-CN.resx
Outdated
Show resolved
Hide resolved
UlyssesWu
approved these changes
Jul 10, 2024
UlyssesWu
approved these changes
Jul 10, 2024
1. Deleted spaces in some resource files. 2. Replaced "\n" with "\r\n" in some resource files (replaced OA with 0D 0A). 3. Added some untranslated strings (Chinese and some Russian). 4. To facilitate comparison of missing translation entries, I adjusted the code order (with the default language resource file as a reference). 5. Some Russian strings are relatively long, and I am worried that they will exceed the display part of the control, so I did not translate them. I hope friends who know Russian can help translate them. 5. In order to ensure that the format of all resource files is consistent, I only use Nopetad3 and WinMergeU for comparison and modification. 6. My non-native language level is very poor, so I use Google for comparison and translation. Of course, for some common words in some software, I refer to them as references.
UlyssesWu
suggested changes
Jul 13, 2024
There was a problem hiding this comment.
No obvious problem for other CN translations.
- Deleted spaces in some resource files.
👎 Personally, I disagree with it. These spaces are always there when Visual Studio creates the resx file. There's no need to remove them, unless a code style rule is set by maintainers.
- Replaced "\n" with "\r\n" in some resource files (replaced OA with 0D 0A).
👍 OK.
- Added some untranslated strings (Chinese and some Russian).
- To facilitate comparison of missing translation entries, I adjusted the code order (with the default language resource file as a reference).
- Some Russian strings are relatively long, and I am worried that they will exceed the display part of the control, so I did not translate them. I hope friends who know Russian can help translate them.
- My non-native language level is very poor, so I use Google for comparison and translation. Of course, for some common words in some software, I refer to them as references.
👎 Why not just waiting for a native Russian speaker to translate them? Especially when your PR name is "Add chinese translation". If you insist to add Russian translations, I'd suggest you to create another PR.
Extensions/dnSpy.Debugger/dnSpy.Debugger/Properties/dnSpy.Debugger.Resources.zh-CN.resx
Outdated
Show resolved
Hide resolved
Extensions/dnSpy.Debugger/dnSpy.Debugger/Properties/dnSpy.Debugger.Resources.zh-CN.resx
Outdated
Show resolved
Hide resolved
1. Reset the modified default resource files and Russian resource files 2. Fixed the Chinese translation, thanks to UlyssesWu for the suggestion Co-Authored-By: Ulysses <[email protected]>
UlyssesWu
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add chinese translation for CloseAllFrameworkAssembliesCommand