Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Fix number of threads used in examples. #9591

Merged
merged 1 commit into from
Sep 23, 2023
Merged

[R] Fix number of threads used in examples. #9591

merged 1 commit into from
Sep 23, 2023

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Sep 18, 2023 •
edited
Loading

  • Set threads for data.table
  • Disable parallel model IO in XGBoost for R.
  • Some helper scripts.

@trivialfis trivialfis mentioned this pull request Sep 18, 2023
Closed
5 tasks
@trivialfis trivialfis marked this pull request as ready for review September 21, 2023 10:54
@trivialfis trivialfis changed the title [R] Set number of threads in demo for DT. [R] Fix number of threads used in examples. Sep 21, 2023
@trivialfis
Copy link
Member Author

tests also have a limit for 2 threads.

@trivialfis
Copy link
Member Author 

Running R code in ‘testthat.R’ had CPU time 3.6 times elapsed time
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking re-building of vignette outputs ... [32s/11s] NOTE
Re-building vignettes had CPU time 3 times elapsed time

@trivialfis
Copy link
Member Author

@jameslamb @hcho3 Would be great if you could help review the PR when you are available, I think we are close to passing the pre-test now.

jameslamb
jameslamb approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

I agree that the benefit of getting {xgboost} v2.0.0 onto CRAN are large enough that it's worth hard-coding in this 2-thread limit for model I/O.

@trivialfis
Copy link
Member Author

We still need to go through the reverse dependency check and talk to downstream projects. So, it might take a long time.

@trivialfis
Copy link
Member Author

Thank you for all the helpful information! @jameslamb .

@trivialfis trivialfis changed the base branch from release_2.0.0 to master September 22, 2023 22:07
@trivialfis trivialfis changed the base branch from master to release_2.0.0 September 22, 2023 22:08
@trivialfis
[R] Set number of threads in demos and tests.
5a58081 
- Restrict the number of threads in IO.
- Specify the number of threads in demos and tests.
- Add helper scripts for checks.
@trivialfis trivialfis changed the base branch from release_2.0.0 to master September 22, 2023 22:11
@trivialfis
Copy link
Member Author

Changed base to master from 2.0.

@trivialfis trivialfis closed this Sep 23, 2023
@trivialfis trivialfis reopened this Sep 23, 2023
@trivialfis trivialfis merged commit cac2cd2 into dmlc:master Sep 23, 2023
25 checks passed
@trivialfis trivialfis deleted the r-nthread branch September 23, 2023 13:44
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Dec 1, 2023
@trivialfis
[backport][R] Set number of threads in demos and tests. (dmlc#9591)
e875314 
- Restrict the number of threads in IO.
- Specify the number of threads in demos and tests.
- Add helper scripts for checks.
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Dec 2, 2023
@trivialfis
Fix R error function format string.
f4903b5 
[backport][R] Set number of threads in demos and tests. (dmlc#9591)

- Restrict the number of threads in IO.
- Specify the number of threads in demos and tests.
- Add helper scripts for checks.

port release script.

Fix sort.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @jameslamb