Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fix NegativeSampler seeds support. #7043

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented Jan 30, 2024

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 30, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@yxy235 yxy235 linked an issue Jan 30, 2024 that may be closed by this pull request
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 30, 2024

Commit ID: 4353899

Build ID: 1

Status: ❌ CI test failed in Stage [Torch CPU Example test].

Report path: link

Full logs path: link

@yxy235
Copy link
Collaborator Author

yxy235 commented Jan 30, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 30, 2024

Commit ID: c788ef61ed4f195f5eb151102b0b5d33c6731402

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 31, 2024

Commit ID: 76d753f91ec8027d4c739a76c94eccf274721354

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 31, 2024

Commit ID: 872eb9d0192a7cf180fa4faf8e404d150662fada

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 merged commit e7c3454 into dmlc:master Jan 31, 2024
2 checks passed
@yxy235 yxy235 deleted the fix_negative_sampler_seeds branch February 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt] Refactor Negative sampler
3 participants