Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphBolt] Refactor Negative sampler #6934

Closed
peizhou001 opened this issue Jan 11, 2024 · 0 comments · Fixed by #6976, #6989, #7001 or #7043
Closed

[GraphBolt] Refactor Negative sampler #6934

peizhou001 opened this issue Jan 11, 2024 · 0 comments · Fixed by #6976, #6989, #7001 or #7043
Assignees
@yxy235 @peizhou001
Labels
Work Item Work items tracked in project tracker
Milestone
2023 12.30 Graphbolt

Comments

@peizhou001
Copy link
Collaborator

🔨Work Item

Currently negative sampler is too complicated and over-optimized, and it only support fixed ratio between positive and negative samples, what's more, it is implicitly assumed negative samples are ordered one by, which scarify flexibility.

Make it simple and flexible, avoid over design and optimization, refer MRR

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

Depending work items or issues
@peizhou001 peizhou001 added the Work Item Work items tracked in project tracker label Jan 11, 2024
@peizhou001 peizhou001 added this to the 2023 12.30 Graphbolt milestone Jan 11, 2024
@peizhou001 peizhou001 self-assigned this Jan 11, 2024
@yxy235 yxy235 linked a pull request Jan 22, 2024 that will close this issue
[GraphBolt] Add check to NegativeSampler. #6976
Merged
8 tasks
@yxy235 yxy235 self-assigned this Jan 22, 2024
@yxy235 yxy235 linked a pull request Jan 22, 2024 that will close this issue
[GraphBolt] Add indexes to MiniBatch. #6989
Merged
8 tasks
@yxy235 yxy235 changed the title Refactor Negative sampler [GraphBolt] Refactor Negative sampler Jan 22, 2024
@yxy235 yxy235 reopened this Jan 23, 2024
@yxy235 yxy235 linked a pull request Jan 25, 2024 that will close this issue
[GraphBolt] Refactor NegativeSampler. #7001
Merged
8 tasks
@yxy235 yxy235 linked a pull request Jan 30, 2024 that will close this issue
[GraphBolt] Fix NegativeSampler seeds support. #7043
Merged
8 tasks
@yxy235 yxy235 reopened this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yxy235 yxy235

@peizhou001 peizhou001

Labels
Work Item Work items tracked in project tracker
Projects
None yet
Milestone
2023 12.30 Graphbolt
2 participants
@yxy235 @peizhou001