Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix runnable/testprofile.d CI regression on Windows #16147

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Feb 4, 2024

I think that test started to rather consistently fail on Windows with #16120. Looking at it, I noticed a functional change, so trying to revert that.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16147"

@kinke
Copy link
Contributor Author

kinke commented Feb 4, 2024

This reverts commit ebd2d81.

It appears to have broken `runnable/testprofile.d` rather consistently
for Windows CI, with weird OutOfMemoryErrors.
@kinke
Copy link
Contributor Author

kinke commented Feb 4, 2024

Okay, now only reverting #16122, and CI passed. Might have been luck, but I don't think so. ;)

@RazvanN7
Copy link
Contributor

RazvanN7 commented Feb 5, 2024

cc @dkorpel

@RazvanN7
Copy link
Contributor

RazvanN7 commented Feb 5, 2024

I'm gonna merge this to unclog the PR queue.

@RazvanN7 RazvanN7 merged commit f62c501 into dlang:master Feb 5, 2024
48 checks passed
@kinke kinke deleted the try_fix_testprofile branch February 5, 2024 11:57
@dkorpel
Copy link
Contributor

dkorpel commented Feb 5, 2024

How do I proceed here? The PR was green when it was merged, and the error is:

core.exception.OutOfMemoryError@src\core\internal\gc\impl\conservative\gc.d(512): Memory allocation failed

Which doesn't follow from the change.

@kinke
Copy link
Contributor Author

kinke commented Feb 5, 2024

The issue isn't deterministic, but almost every pipeline since then contained at least one Windows job that failed. The test itself doesn't really allocate anything, so looks like some implicit demangling for profiling broke, somehow on Windows only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants