This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Wrap id's of selectors in quotes #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the cases with newer jQuery where selector contains dot characters.
adamchainz
pushed a commit
to adamchainz/gargoyle
that referenced
this pull request
Feb 12, 2016
Merges disqus#73. This fixes the cases with newer jQuery where selector contains dot characters.
adamchainz
pushed a commit
to adamchainz/gargoyle
that referenced
this pull request
Feb 12, 2016
Merges disqus#73. This fixes the cases with newer jQuery where selector contains dot characters.
|
Merged into the YPlan fork at YPlan/gargoyle#34 , with the Nexus jQuery upgrade in adamchainz/nexus#43 . Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cases with newer jQuery where selector contains dot characters.
Attempting to fix this issue: #72
jQuery version used by Nexus would still need to be updated to fix the issue completely.