Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Merge outstanding pull requests from disqus/gargoyle #12

Open
adamchainz opened this issue Jan 9, 2016 · 2 comments
Open

Merge outstanding pull requests from disqus/gargoyle #12

adamchainz opened this issue Jan 9, 2016 · 2 comments

Comments

@adamchainz
Copy link
Owner

Currently open PRs and judgment:

  1. Condition rename: myapp/gargoyle.py shadows gargoyle package disqus/gargoyle#3 Condition rename: myapp/gargoyle.py shadows gargoyle package
    ❌ Should be closed, just an absolute_import issue
  2. Add session specific controls to dashboard so that users who have permiss disqus/gargoyle#13 Add session specific controls to dashboard so that users who have permiss
    Possibly useful, but it's a major feature and has no extra +1 requests/subscribers so likely not wanted by many
  3. Added Jinja template tag disqus/gargoyle#17 Added Jinja template tag
    Probably useful but likely to need signficant reworking to work with Django's new Jinja template engine.
  4. add is_active stringfilter disqus/gargoyle#32 add is_active stringfilter
    Good idea but should rename it or figure out a way of adding a variable to the context.
  5. add SwitchActiveMixin to check for gargoyle switch disqus/gargoyle#43 add SwitchActiveMixin to check for gargoyle switch
    LGTM, but no upvotes.
  6. Fixed range condition disqus/gargoyle#55 Fixed range condition
    ✅ We have merged in Update gargoyle/conditions.py #22.
  7. Wrap id's of selectors in quotes disqus/gargoyle#73 Wrap id's of selectors in quotes
    ✅ We have merged in Wrap id's of selectors in quotes #34 , with nexus jQuery upgrade merged in Upgrade jQuery to 1.6.4 nexus#43.
  8. Add ifnotswitch template tag disqus/gargoyle#92 Add ifnotswitch template tag
    ✅ We have merged in Add ifnotswitch template tag #37.
  9. Cannot add conditions in Nexus disqus/gargoyle#98 Cannot add conditions in Nexus
    ✅ We fixed the issue rather than merge the documentation update. Wrap id's of selectors in quotes #34 fixed some of the problems with spaces, Fix Nexus admin interface for Switches with spaces in their keys #38 fixed the remainder.
  10. throw exception when key longer than 64 characters disqus/gargoyle#103 throw exception when key longer than 64 characters
    ❌ Thought about it in throw exception when key longer than 64 characters #28, but ultimately consider not worth merging - MySQL users should just activate strict mode
@matclayton
Copy link

#55 I wrote originally and the range condition doesn't split up the input data without this patch and will cause a 500, it shouldn't be hard to confirm

@adamchainz
Copy link
Owner Author

Thanks @matclayton , will try merge later today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants