feat(InteractionResponses): support with_response query parameter #10499
+338
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
We'll wait for #10488 before this one lands. |
Jiralite
reviewed
Sep 12, 2024
vladfrangu
previously requested changes
Sep 12, 2024
packages/discord.js/src/structures/InteractionCallbackResponse.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10499 +/- ##
==========================================
+ Coverage 35.48% 35.49% +0.01%
==========================================
Files 228 228
Lines 14308 14303 -5
Branches 1254 1254
==========================================
Hits 5077 5077
+ Misses 9187 9182 -5
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Please resolve conflicts! |
Jiralite
previously requested changes
Oct 12, 2024
packages/discord.js/src/structures/InteractionCallbackResponse.js
Outdated
Show resolved
Hide resolved
sdanialraza
suggested changes
Nov 11, 2024
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
almeidx
previously requested changes
Nov 13, 2024
cobaltt7
reviewed
Nov 13, 2024
monbrey
force-pushed
the
with_response
branch
from
a598257
to
111b3dd
Compare
Jiralite
previously requested changes
Nov 14, 2024
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jiralite <[email protected]>
Jiralite
approved these changes
Nov 15, 2024
vladfrangu
previously requested changes
Nov 16, 2024
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
Jiralite
requested changes
Nov 17, 2024
Co-authored-by: Jiralite <[email protected]>
Jiralite
requested changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #10498
/core done in #10512
Upstream: discord/discord-api-docs#7106
Status and versioning classification: