fix: suggestions from code review

discordjs · Nov 13, 2024 · a598257 · a598257
1 parent 569ce9e
commit a598257
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 25 deletions.
diff --git a/packages/discord.js/src/structures/InteractionCallback.js b/packages/discord.js/src/structures/InteractionCallback.js
@@ -27,39 +27,27 @@ class InteractionCallback {
      */
     this.type = data.type;
 
-    /**
-     * The id of the channel the original interaction was sent in
-     * @type {?Snowflake}
-     */
-    this.channelId = data.channel_id ?? null;
-
-    /**
-     * The id of the guild the original interaction was sent in
-     * @type {Snowflake}
-     */
-    this.guildId = data.guild_id ?? null;
-
     /**
      * The instance id of the Activity if one was launched or joined
-     * @type {string}
+     * @type {?string}
      */
     this.activityInstanceId = data.activity_instance_id ?? null;
 
     /**
      * The id of the message that was created by the interaction
-     * @type {Snowflake}
+     * @type {?Snowflake}
      */
     this.responseMessageId = data.response_message_id ?? null;
 
     /**
      * Whether the message is in a loading state
-     * @type {boolean}
+     * @type {?boolean}
      */
     this.responseMessageLoading = data.response_message_loading ?? null;
 
     /**
      * Whether the response message was ephemeral
-     * @type {boolean}
+     * @type {?boolean}
      */
     this.responseMessageEphemeral = data.response_message_ephemeral ?? null;
   }

diff --git a/packages/discord.js/src/structures/InteractionCallbackResource.js b/packages/discord.js/src/structures/InteractionCallbackResource.js
@@ -1,4 +1,5 @@
 'use strict';
+
 const { lazy } = require('@discordjs/util');
 
 const getMessage = lazy(() => require('./Message').Message);

diff --git a/packages/discord.js/src/structures/InteractionCallbackResponse.js b/packages/discord.js/src/structures/InteractionCallbackResponse.js
@@ -2,6 +2,7 @@
 
 const InteractionCallback = require('./InteractionCallback');
 const InteractionCallbackResource = require('./InteractionCallbackResource');
+
 /**
  * Represents an interaction's response
  */
@@ -22,7 +23,7 @@ class InteractionCallbackResponse {
     this.interaction = new InteractionCallback(client, data.interaction);
 
     /**
-     * 	The resource that was created by the interaction response
+     * The resource that was created by the interaction response
      * @type {?InteractionCallbackResource}
      */
     this.resource = data.resource ? new InteractionCallbackResource(client, data.resource) : null;

diff --git a/packages/discord.js/src/structures/interfaces/InteractionResponses.js b/packages/discord.js/src/structures/interfaces/InteractionResponses.js
@@ -96,9 +96,9 @@ class InteractionResponses {
 
     if (options.withResponse) {
       return new InteractionCallbackResponse(this.client, response);
-    } else {
-      return options.fetchReply ? this.fetchReply() : new InteractionResponse(this);
     }
+
+    return options.fetchReply ? this.fetchReply() : new InteractionResponse(this);
   }
 
   /**
@@ -143,9 +143,9 @@ class InteractionResponses {
 
     if (options.withResponse) {
       return new InteractionCallbackResponse(this.client, response);
-    } else {
-      return options.fetchReply ? this.fetchReply() : new InteractionResponse(this);
     }
+
+    return options.fetchReply ? this.fetchReply() : new InteractionResponse(this);
   }
 
   /**
@@ -235,9 +235,9 @@ class InteractionResponses {
 
     if (options.withResponse) {
       return new InteractionCallbackResponse(this.client, response);
-    } else {
-      return options.fetchReply ? this.fetchReply() : new InteractionResponse(this, this.message?.interaction?.id);
     }
+
+    return options.fetchReply ? this.fetchReply() : new InteractionResponse(this, this.message?.interaction?.id);
   }
 
   /**
@@ -275,9 +275,9 @@ class InteractionResponses {
 
     if (options.withResponse) {
       return new InteractionCallbackResponse(this.client, response);
-    } else {
-      return options.fetchReply ? this.fetchReply() : new InteractionResponse(this, this.message.interaction?.id);
     }
+
+    return options.fetchReply ? this.fetchReply() : new InteractionResponse(this, this.message.interaction?.id);
   }
 
   /**