fix: update 'No data' handling #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
jenniferarnesen
approved these changes
Nov 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
## [4.0.1](v4.0.0...v4.0.1) (2024-11-29) ### Bug Fixes * update 'No data' handling ([#596](#596)) ([1fbdb20](1fbdb20))
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DHIS2-18427
Linked maps-app PR: dhis2/maps-app#3408
Linked maps-app v39 PR: dhis2/maps-app#3415
maps-gl/src/layers/Layer.js
Line 350 in f1bfa61
Note: Here nodata label is passed directly from maps-app instead of from Map.locale as the "label layer" source is not created in the Map context.
maps-gl/src/utils/labels.js
Line 35 in f1bfa61
Before:
After:
