Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update 'No data' handling [v39] #3415

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: update 'No data' handling [v39] #3415

merged 3 commits into from
Nov 29, 2024

Conversation

BRaimbault
Copy link
Collaborator

@BRaimbault BRaimbault commented Nov 25, 2024

Implement DHIS2-18427
Linked maps-gl PR: dhis2/maps-gl#596
Backport of PR: #3408


Note ?? cannot be used with version of eslint (babel/babel-eslint#611), using value !== null && value !== undefined ? ... : ... instead.


Checklist:

  • Jest tests added
  • Cypress tests added
  • Manual testing complete
  • Dashboard tested
  • Update maps-gl dependency (to not point to d2-ci)

Before:
image

After:
image

@BRaimbault BRaimbault mentioned this pull request Nov 25, 2024
5 tasks
Copy link

cypress bot commented Nov 25, 2024

maps    Run #3360

Run Properties:  status check passed Passed #3360  •  git commit 45abac00b6: chore: maps-gl dependency bump
Project maps
Branch Review fix/DHIS2-18427-v39
Run status status check passed Passed #3360
Run duration 08m 34s
Commit git commit 45abac00b6: chore: maps-gl dependency bump
Committer Bruno Raimbault
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 14
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 36
View all changes introduced in this branch ↗︎

@BRaimbault BRaimbault marked this pull request as ready for review November 25, 2024 12:14
@BRaimbault BRaimbault merged commit 9b39108 into v39 Nov 29, 2024
8 checks passed
@BRaimbault BRaimbault deleted the fix/DHIS2-18427-v39 branch November 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants