feat: use PeriodDimension in ThematicDialog #3407
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3407.maps.netlify.dhis2.org |
2 tasks
| height: `${32 + rectTotalHeight}`, | ||
| bottom: `30`, | ||
| height: `${32 + rectTotalHeight}px`, | ||
| bottom: `30px`, |
There was a problem hiding this comment.
I don't think the backward tics are needed, just regular single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement: DHIS2-15796
Linked @dhis2/analytics PR: dhis2/analytics#1735
WORK IN PROGRESS
Main changes are:
SegmentedControlto select period type (presets / start-end dates)PeriodDimensionperiod selector (transfer-style) for preset periodsRenderingStrategythat controls the use of single map / timeline / split-mapStartEndDatefor start-end dates periods1.
SegmentedControl2.
PeriodDimensionThe new period selector used is
PeriodDimension(transfer-style) is defined in@dhis2/analytics.Most of the changes are orchestrated in:
And relies on modifications to support multiple periods:
We also updated and rename
StartEndDatestoStartEndDateto align with the Linelisting app but with an updated date pickerCalendarInputfrom@dhis2/uiwhich supports multiple calendars.EventDialogandTrackedEntityDialogare also updated to useStartEndDate:Small adjustments to
RadioGroupare madeSmall adjustment to InterpretationMap is made to handle and array of periods:
Smaller quality of life improvements are included:
Smaller bug fixes are included:
Checklist:
Before:
After: