Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use PeriodDimension in ThematicDialog #3407

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
0ee3fad
feat: use PeriodDimension in ThematicDialog
BRaimbault Nov 18, 2024
537c0f7
Merge branch 'master' into feat/DHIS2-15796
BRaimbault Nov 18, 2024
06d6d71
feat: support multiple periods
BRaimbault Nov 19, 2024
67ff60d
fix: PeriodDimension style
BRaimbault Nov 20, 2024
7b3545a
fix: get default relative periods labels
BRaimbault Nov 25, 2024
b2be0ed
feat: use PeriodDimension in ThematicDialog
BRaimbault Dec 2, 2024
748150e
Merge branch 'master' into feat/DHIS2-15796
BRaimbault Dec 2, 2024
c224835
Merge branch 'master' into feat/DHIS2-15796
BRaimbault Dec 3, 2024
fcda751
feat: use PeriodDimension in ThematicDialog
BRaimbault Dec 3, 2024
c1c8a4a
feat: use PeriodDimension in ThematicDialog
BRaimbault Dec 4, 2024
12159df
Merge branch 'master' into feat/DHIS2-15796
BRaimbault Dec 5, 2024
68ac83b
fix: correct RenderingStrategy periods count
BRaimbault Dec 5, 2024
a4322fb
fix: use CalendarInput in StartEndDate
BRaimbault Dec 6, 2024
b80c33c
feat: handle multiple periods in timeline
BRaimbault Dec 6, 2024
dbd09ba
feat: use PeriodDimension in ThematicDialog
BRaimbault Dec 9, 2024
245848a
fix: add sumObjectValues helper and test
BRaimbault Dec 10, 2024
e744748
fix: add getPeriodsDurationByType util and test
BRaimbault Dec 10, 2024
25d9700
fix: refactor RenderingStrategy and add test
BRaimbault Dec 10, 2024
86e6f18
fix: refactor Timeline
BRaimbault Dec 10, 2024
c6c6fcf
fix: refactor Timeline
BRaimbault Dec 11, 2024
170ac85
fix: refactor Timeline
BRaimbault Dec 11, 2024
cd32b22
Merge branch 'master' into feat/DHIS2-15796
BRaimbault Dec 11, 2024
709a8ba
chore: clean-up
BRaimbault Dec 12, 2024
2d74cb0
chore: clean-up
BRaimbault Dec 12, 2024
051a9bd
fix: update periodError handling
BRaimbault Dec 12, 2024
5d7c55d
fix: handle multiple periods in interpretations
BRaimbault Dec 13, 2024
9f4ad67
fix: avoid defaulting to period tab
BRaimbault Dec 13, 2024
07dd32f
feat: add closing buttons "x"
BRaimbault Dec 13, 2024
1487d0b
feat: additional keyboard controls
BRaimbault Dec 13, 2024
aff5044
fix: timeline not visible in Firefox
BRaimbault Dec 18, 2024
c0d7028
chore: fix cypress tests
BRaimbault Dec 20, 2024
91a69bb
chore: fix cypress tests
BRaimbault Dec 20, 2024
5b09c6e
chore: cypress update
BRaimbault Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/periods/Timeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ class Timeline extends Component {
<svg
className={`dhis2-map-timeline ${styles.timeline}`}
style={{
height: `${32 + rectTotalHeight}`,
bottom: `30`,
height: `${32 + rectTotalHeight}px`,
bottom: `30px`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the backward tics are needed, just regular single quotes.

}}
>
{/* Play/Pause Button */}
Expand Down
Loading