-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use PeriodDimension in ThematicDialog #3407
Draft
BRaimbault
wants to merge
33
commits into
master
Choose a base branch
from
feat/DHIS2-15796
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0ee3fad
feat: use PeriodDimension in ThematicDialog
BRaimbault 537c0f7
Merge branch 'master' into feat/DHIS2-15796
BRaimbault 06d6d71
feat: support multiple periods
BRaimbault 67ff60d
fix: PeriodDimension style
BRaimbault 7b3545a
fix: get default relative periods labels
BRaimbault b2be0ed
feat: use PeriodDimension in ThematicDialog
BRaimbault 748150e
Merge branch 'master' into feat/DHIS2-15796
BRaimbault c224835
Merge branch 'master' into feat/DHIS2-15796
BRaimbault fcda751
feat: use PeriodDimension in ThematicDialog
BRaimbault c1c8a4a
feat: use PeriodDimension in ThematicDialog
BRaimbault 12159df
Merge branch 'master' into feat/DHIS2-15796
BRaimbault 68ac83b
fix: correct RenderingStrategy periods count
BRaimbault a4322fb
fix: use CalendarInput in StartEndDate
BRaimbault b80c33c
feat: handle multiple periods in timeline
BRaimbault dbd09ba
feat: use PeriodDimension in ThematicDialog
BRaimbault 245848a
fix: add sumObjectValues helper and test
BRaimbault e744748
fix: add getPeriodsDurationByType util and test
BRaimbault 25d9700
fix: refactor RenderingStrategy and add test
BRaimbault 86e6f18
fix: refactor Timeline
BRaimbault c6c6fcf
fix: refactor Timeline
BRaimbault 170ac85
fix: refactor Timeline
BRaimbault cd32b22
Merge branch 'master' into feat/DHIS2-15796
BRaimbault 709a8ba
chore: clean-up
BRaimbault 2d74cb0
chore: clean-up
BRaimbault 051a9bd
fix: update periodError handling
BRaimbault 5d7c55d
fix: handle multiple periods in interpretations
BRaimbault 9f4ad67
fix: avoid defaulting to period tab
BRaimbault 07dd32f
feat: add closing buttons "x"
BRaimbault 1487d0b
feat: additional keyboard controls
BRaimbault aff5044
fix: timeline not visible in Firefox
BRaimbault c0d7028
chore: fix cypress tests
BRaimbault 91a69bb
chore: fix cypress tests
BRaimbault 5b09c6e
chore: cypress update
BRaimbault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the backward tics are needed, just regular single quotes.