Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: period type select refactor #2977

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

turban
Copy link
Contributor

@turban turban commented Sep 16, 2023

This PR will refactor the period type selector:

  • clearPeriod boolean is changed to keepPeriod boolean to simplify the code. If keepPeriod is true, we will not clear the period when the period type is changed.
  • hiddenPeriods systems settings is read in the PeriodTypeSelect component so we don't need to pass it in as a property.
  • It is possible to show the period type select without the "Relative" option. We will use this later for some Earth Engine layers not supporting relative periods.
  • The code setting the default period type was simplified: By default it will be set to the first option (which will be still be "Relative" for thematic layers). If we load a saved map, we will set the period type to "Relative" (first option) if a relative period is used.

For thematic layers there should be no change in behaviour with this code change.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 16, 2023

🚀 Deployed on https://pr-2977--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 16, 2023 12:37 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 16, 2023 12:44 Inactive
@cypress
Copy link

cypress bot commented Sep 16, 2023

Passing run #2593 ↗︎

0 38 20 0 Flakiness 0

Details:

Merge c2557cc into 5d33ca5...
Project: maps Commit: 85826306e2 ℹ️
Status: Passed Duration: 05:22 💡
Started: Sep 27, 2023 3:15 PM Ended: Sep 27, 2023 3:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dhis2-bot dhis2-bot temporarily deployed to netlify September 16, 2023 12:58 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 16, 2023 13:04 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 27, 2023 12:22 Inactive
@turban turban changed the base branch from dev to ee-dev September 27, 2023 12:32
@dhis2-bot dhis2-bot temporarily deployed to netlify September 27, 2023 15:00 Inactive
@turban turban merged commit 7cd5114 into ee-dev Sep 27, 2023
11 checks passed
@turban turban deleted the chore/period-type-select-refactor branch September 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants