Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Earth Engine layers update and Maps Admin auth managing layer sources #3158

Merged
merged 40 commits into from
Jul 31, 2024

Conversation

turban
Copy link
Contributor

@turban turban commented Mar 19, 2024

See descriptions in the PRs below.

PRs that are already merged to this branch:

PR for maps-gl dependency:

PR for v39 backport:

Next steps:

  • Extensive testing for this PR and v39 PR:
    • All functionalities
      • this PR
      • v39 PR
    • Test adding new eelayers
      • this PR
    • Dashboard plugin
      • this PR
      • v39 PR
  • Agree on versions (maps-gl v4.0 and maps-app v100.6 ?)
  • Merge the maps-gl dependency.
  • Update the maps-gl dependency in this PR and v39 PR.
  • Merge ee-dev into master.

@turban turban changed the base branch from dev to master March 19, 2024 17:25
@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 8, 2024

🚀 Deployed on https://pr-3158--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 8, 2024 14:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 8, 2024 14:35 Inactive
@turban turban changed the title DRAFT: ee-dev DRAFT: Earth Engine layers refactor May 8, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify June 17, 2024 13:57 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 25, 2024 08:15 Inactive
Implement: https://dhis2.atlassian.net/browse/DHIS2-16098
Reserve DHIS2_MAPS_APP_CORE namespace in app config.
Add dataStore handling hook.
Add redux store to handle managed layer sources. 
Add manage layer sources button and modal components accessible
to maps admin user (authority: F_EXTERNAL_MAP_LAYER_PUBLIC_ADD).
Add/update cypress tests.
Include @google/earthengine patch to support service worker,
it was previously included in @dhis2/maps-gl as a custom version of the library.

---------

Co-authored-by: Jen Jones Arnesen <[email protected]>
Co-authored-by: Bruno Raimbault <[email protected]>
@dhis2-bot dhis2-bot temporarily deployed to netlify July 29, 2024 09:32 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 29, 2024 10:16 Inactive
* feat: new unmask aggregation param
@dhis2-bot dhis2-bot temporarily deployed to netlify July 29, 2024 10:27 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 29, 2024 12:34 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 30, 2024 13:59 Inactive
@turban turban changed the title DRAFT: Earth Engine layers refactor Earth Engine layers refactor Jul 31, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify July 31, 2024 06:34 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 31, 2024 06:40 Inactive
@turban turban changed the title Earth Engine layers refactor Allow admins to select Earth Engine layers to show in the app Jul 31, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify July 31, 2024 08:09 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 31, 2024 09:12 Inactive
@BRaimbault BRaimbault changed the title Allow admins to select Earth Engine layers to show in the app feat: Earth Engine layers update and Maps Admin auth managing layer sources Jul 31, 2024
@BRaimbault BRaimbault merged commit d0f0b92 into master Jul 31, 2024
21 checks passed
@BRaimbault BRaimbault deleted the ee-dev branch July 31, 2024 09:36
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants