chore (indicator types list): add extra form validation

i18n/en.pot

@@ -5,6 +5,8 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
+"POT-Creation-Date: 2024-11-27T08:30:38.416Z\n"
+"PO-Revision-Date: 2024-11-27T08:30:38.417Z\n"
 "POT-Creation-Date: 2024-11-26T14:06:00.934Z\n"
 "PO-Revision-Date: 2024-11-26T14:06:00.934Z\n"
 

src/components/form/fields/DateField.tsx

@@ -1,6 +1,6 @@
 import i18n from '@dhis2/d2-i18n'
 import { CalendarInput, CalendarInputProps } from '@dhis2/ui'
-import React, { useEffect, useState } from 'react'
+import React, { useState } from 'react'
 import { useField } from 'react-final-form'
 import { selectedLocale, useSystemSetting } from '../../../lib'
 
@@ -31,7 +31,7 @@
         error: false,
     })
 
     const { input, meta } = useField<string | undefined>(name)
 
     const handleChange: CalendarInputProps['onDateSelect'] = (
         payload: {

src/pages/indicatorTypes/form/IndicatorTypesSchema.ts

@@ -4,7 +4,16 @@ import { getDefaults, createFormValidate, modelFormSchemas } from '../../../lib'
 const { identifiable } = modelFormSchemas
 
 export const IndicatorSchema = identifiable.extend({
-    factor: z.coerce.number().int(),
+    factor: z.coerce
+        .number({ invalid_type_error: 'Please enter a number' })
+        .int()
+        .max(
+            Number.MAX_SAFE_INTEGER,
+            `The number is too large. Please enter a valid integer.`
+        )
+        .refine((value) => value !== 0, {
+            message: 'Zero is not a valid value for factor',
+        }),
 })
 
 export const initialValues = getDefaults(IndicatorSchema)