Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (indicator types list): add extra form validation #450

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Nov 25, 2024

Implements DHIS2-18284

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 9411710
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/6748548996510000088d7f05
😎 Deploy Preview https://deploy-preview-450--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@flaminic flaminic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above, i think we need to allow for negative numbers

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (f3812fc) to head (66da56f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   60.64%   60.67%   +0.02%     
==========================================
  Files         212      212              
  Lines        3372     3372              
  Branches      749      749              
==========================================
+ Hits         2045     2046       +1     
+ Misses       1319     1318       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chisomchima Chisomchima requested a review from flaminic November 27, 2024 11:44
@Chisomchima Chisomchima merged commit 3c78f90 into master Nov 28, 2024
8 of 9 checks passed
@Chisomchima Chisomchima deleted the DHIS2-18283-indicator-types-list branch November 28, 2024 11:33
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants