-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (indicator types list): add extra form validation #450
Conversation
…o DHIS2-18283-indicator-types-list
…o DHIS2-18283-indicator-types-list
…o DHIS2-18283-indicator-types-list
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above, i think we need to allow for negative numbers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 60.64% 60.67% +0.02%
==========================================
Files 212 212
Lines 3372 3372
Branches 749 749
==========================================
+ Hits 2045 2046 +1
+ Misses 1319 1318 -1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 0.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements DHIS2-18284