fix: extract the start-end-date part of the item id #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Jan 24, 2024
|
🚀 Deployed on https://pr-486--dhis2-line-listing.netlify.app |
jenniferarnesen
merged commit d974ec3
into
feat/tracked-entity-input
12 of 17 checks passed
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where Period Dimension doesn't recognize the start/end date that has been selected for a time dimension
Perhaps the
extractDimensionIdPartsshould be renamed, since it is also used to get the selected item for the dimension?