-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tracked entity input (DHIS2-16023) #451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
program is an object that changes at each render triggering the fetch every time. Instead, use a memoized program.id which is the only thing needed in the fetch. Memoize also setIsListEndVisible to avoid returning a difference function from the hook.
…racked-entity-input
🚀 Deployed on https://pr-451--dhis2-line-listing.netlify.app |
martinkrulltott
changed the title
feat: tracked entity input
feat: tracked entity input (DHIS2-16023)
Oct 24, 2023
Base automatically changed from
feat/DHIS2-15454-sidebar-ui-changes
to
master
October 25, 2023 13:24
jenniferarnesen
approved these changes
Apr 12, 2024
dhis2-bot
added a commit
that referenced
this pull request
Apr 12, 2024
# [100.16.0](v100.15.1...v100.16.0) (2024-04-12) ### Features * tracked entity input (DHIS2-16023) ([#451](#451)) ([a59f19e](a59f19e))
🎉 This PR is included in version 100.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16023
Requires dhis2/analytics#1594
Figma
Spec
Netlify
Cypress bot message
Cypress dashboard
Key features
Tracked entity
Description
The following is only a quick summary of what this PR contains, for full details see the spec and Figma links above.
A new input type ("Tracked entity") was added to the input panel for creating TE line lists. After selecting a tracked entity type (TET), associated dimensions can be selected through the new TET dimension menu item (e.g. "Person dimensions"). There are two new global dimensions, "Registration org. unit" and "Registration date". The program dimensions panel now supports cross-program selection for TE.
All of the above are featured toggled to v41. Because of that, the
nightly.yml
workflow has temporarily been modified to run the CI Cypress tests againstdev
.Because of the cross-program aspect of TE, all uses of dimension id's now need to go through
extractDimensionIdParts
andformatDimensionId
to be prefixed/unprefixed correctly.TODO
nightly.yml
Known issues
withTrackedEntityType
for the Analytics requestNaN
values DHIS2-16382pid.sid.did
metadata (where the legend set is fetched). Backend issue DHIS2-16379ou
dimension and apid.ou
dimension causes the items for each to get mixed up and be added to both dimensions. This is caused by the backend not keeping the items separated. DHIS2-16419undefined
instead ofTrue
andFalse
+ conditions can't be used DHIS2-16513/eventVisualizations
(Slack discussion / DHIS2-16437)stageOffset
DHIS2-16742Screenshots
New input type "Tracked entity"
New dimension menu item for tracked entity type dimensions
New global dimensions "Registration org. unit" and "Registration date"
Program dimensions panel with cross-program selection
New suffix logic for cross-program selection using program or stage depending on the type of duplicate