Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) v39 #3094

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Jun 12, 2024

Implements DHIS2-16172

Requires dhis2/analytics#1679


Backport of #3093 to 39

@dhis2-bot
Copy link
Contributor

Copy link

cypress bot commented Jun 12, 2024

Passing run #2886 ↗︎

0 629 0 0 Flakiness 0

Details:

Merge 5d563e2 into ad73dd9...
Project: Data Visualizer App Commit: e60e645f75 ℹ️
Status: Passed Duration: 10:23 💡
Started: Jun 12, 2024 1:13 PM Ended: Jun 12, 2024 1:23 PM

Review all test suite changes for PR #3094 ↗︎

@martinkrulltott martinkrulltott requested a review from edoardo June 12, 2024 13:49
@martinkrulltott martinkrulltott changed the title fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) v39 Jun 13, 2024
@martinkrulltott martinkrulltott merged commit 82b6e03 into 39.x Jun 13, 2024
14 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-16172-pie-labels-39 branch June 13, 2024 09:38
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 39.2.35 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants