Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) v39 #3000

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Jun 13, 2024

Implements DHIS2-16172

Requires dhis2/analytics#1679

Requires dhis2/data-visualizer-app#3094


Backport to bump the analytics and dv plugin versions

@martinkrulltott martinkrulltott requested a review from edoardo June 13, 2024 09:57
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 13, 2024

🚀 Deployed on https://pr-3000--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 13, 2024 09:59 Inactive
Copy link

cypress bot commented Jun 13, 2024

Passing run #4885 ↗︎

0 58 0 0 Flakiness 0

Details:

Merge branch 'v39' into fix/DHIS2-16172-pie-labels-39
Project: dashboards-app Commit: a8e71148f6
Status: Passed Duration: 05:02 💡
Started: Jun 14, 2024 7:09 AM Ended: Jun 14, 2024 7:14 AM

Review all test suite changes for PR #3000 ↗︎

@martinkrulltott martinkrulltott enabled auto-merge (squash) June 13, 2024 12:32
@dhis2-bot dhis2-bot temporarily deployed to netlify June 14, 2024 07:07 Inactive
@martinkrulltott martinkrulltott merged commit 812cfa4 into v39 Jun 14, 2024
13 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-16172-pie-labels-39 branch June 14, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants