Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) #3093

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) #3093

merged 2 commits into from
Jun 12, 2024

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Jun 12, 2024 •
edited by jira bot
Loading

Implements DHIS2-16172

Requires dhis2/analytics#1677

See Analytics PR for info and screenshots

@martinkrulltott martinkrulltott mentioned this pull request Jun 12, 2024
Merged
2 tasks
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 12, 2024 •
edited
Loading

🚀 Deployed on https://pr-3093--dhis2-data-visualizer.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 12, 2024 10:33 Inactive
@martinkrulltott martinkrulltott requested a review from edoardo June 12, 2024 10:34
@dhis2-bot dhis2-bot temporarily deployed to netlify June 12, 2024 11:31 Inactive
@martinkrulltott martinkrulltott mentioned this pull request Jun 12, 2024
Merged
@martinkrulltott martinkrulltott added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jun 12, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 12, 2024

Passing run #2887 ↗︎

0 738 2 0 Flakiness 0

Details:

Merge b8ac85d into 3cedfa6...
Project: Data Visualizer App Commit: 7339283276 ℹ️
Status: Passed Duration: 09:17 💡
Started: Jun 12, 2024 1:21 PM Ended: Jun 12, 2024 1:30 PM

Review all test suite changes for PR #3093 ↗︎

@martinkrulltott martinkrulltott merged commit 5615690 into dev Jun 12, 2024
53 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-16172-pie-labels branch June 12, 2024 13:50
@martinkrulltott martinkrulltott removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jun 14, 2024
jenniferarnesen pushed a commit that referenced this pull request Jun 14, 2024
@martinkrulltott @jenniferarnesen
fix: separator for hundreds, thousands and millions is missing in the…
8be70b8 
… Pie charts (DHIS2-16172) (#3093)
jenniferarnesen pushed a commit that referenced this pull request Jun 17, 2024
@martinkrulltott @jenniferarnesen
fix: separator for hundreds, thousands and millions missing in Pie ch…
286de25 
…arts (DHIS2-16172) (#3093)
dhis2-bot added a commit that referenced this pull request Jun 17, 2024
@dhis2-bot
chore(release): cut 100.5.6 [skip release]
6704c81 
## [100.5.6](v100.5.5...v100.5.6) (2024-06-17)

### Bug Fixes

* separator for hundreds, thousands and millions missing in Pie charts (DHIS2-16172) ([#3093](#3093)) ([286de25](286de25))
* use improved rich text editor from analytics (DHIS2-15522) ([03069f1](03069f1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoardo edoardo edoardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinkrulltott @dhis2-bot @edoardo