Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a crash when row totals is enabled (DHIS2-17297) #3042

Merged
merged 3 commits into from
May 8, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented May 2, 2024

Implements DHIS2-17297

Requires dhis2/analytics#1660


Key features

  1. the actual fix is in analytics

Description

See the ticket and the analytics' PR description.


TODO

  • Cypress tests
  • Manual testing
  • Update analytics dep once this PR is merged

Screenshots

Before:
Screenshot 2024-05-02 at 11 45 32

After:
Screenshot 2024-05-02 at 11 57 56

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 2, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify May 2, 2024 10:09 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 3, 2024 08:28 Inactive
@edoardo edoardo force-pushed the fix/pt-totals-crash branch from 586c590 to 1c8bb73 Compare May 6, 2024 11:39
@dhis2-bot dhis2-bot temporarily deployed to netlify May 6, 2024 11:55 Inactive
@edoardo edoardo enabled auto-merge (squash) May 8, 2024 08:50
@edoardo edoardo merged commit 4004455 into dev May 8, 2024
38 checks passed
@edoardo edoardo deleted the fix/pt-totals-crash branch May 8, 2024 11:49
dhis2-bot added a commit that referenced this pull request May 13, 2024
## [100.5.4](v100.5.3...v100.5.4) (2024-05-13)

### Bug Fixes

* avoid flashing when ou levels are used (DHIS2-17136) ([#3032](#3032)) ([b1b6148](b1b6148))
* fix a crash when row totals is enabled (DHIS2-17297) ([#3042](#3042)) ([4004455](4004455))
* **translations:** sync translations from transifex (dev) ([f1a14b8](f1a14b8))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

kabaros pushed a commit that referenced this pull request May 30, 2024
## [100.5.4](v100.5.3...v100.5.4) (2024-05-13)

### Bug Fixes

* avoid flashing when ou levels are used (DHIS2-17136) ([#3032](#3032)) ([b1b6148](b1b6148))
* fix a crash when row totals is enabled (DHIS2-17297) ([#3042](#3042)) ([4004455](4004455))
* **translations:** sync translations from transifex (dev) ([f1a14b8](f1a14b8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants