fix: fix a crash when row totals is enabled (DHIS2-17297) #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
edoardo
force-pushed
the
fix/pt-totals-crash
branch
from
98f32c6 to
8cf9f3f
Compare
janhenrikoverland
approved these changes
May 6, 2024
dhis2-bot
added a commit
that referenced
this pull request
May 6, 2024
## [26.6.8](v26.6.7...v26.6.8) (2024-05-06) ### Bug Fixes * fix a crash when row totals is enabled (DHIS2-17297) ([#1660](#1660)) ([be6ea56](be6ea56))
|
🎉 This PR is included in version 26.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17297
Relates to dhis2/data-visualizer-app#3042
Key features
Description
More info in the ticket.
In short, a bug was introduced with the cumulative values feature with this commit.
The bug only happens in specific circumstances, which seem to be the following:
With these conditions I was able to reproduce the crash.
Screenshots
Here's a screenshot of the layout in DV which triggers the crash; once column totals is enabled and Update is clicked, the app crashes: