test: add cypress tests for Outlier table DHIS2-17162 #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3008--dhis2-data-visualizer.netlify.app |
1 flaky test on run #2762 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Event data items correctly |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3008 ↗︎
| cy.getBySel(dataTypesSelectButtonEl).click() | ||
| cy.getBySelLike(dataTypeSelectOptionEl).contains(dataType).click() | ||
| cy.getBySel(dataTypesSelectButtonEl).then(($typesSelect) => { | ||
| // account for disabled type selector with preselected item |
There was a problem hiding this comment.
In which case is this needed to have?
!$typesSelect.text().includes(dataType) looks over-engineered to me 🤔
There was a problem hiding this comment.
I added a comment, perhaps is not very clear 😅
Basically, when you have only 1 type enabled, the whole select gets disabled with the preselected type, then the actions for selecting the type don't work.
So, the reasoning is, if the type you want is already selected, don't try to select it again, this accounts also for the case of only 1 type available described above.
Needed by cypress-tags.
edoardo
force-pushed
the
test/cypress-for-outlier-table
branch
from
708e1c8 to
d171fee
Compare
martinkrulltott
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17162
Key features
Description
Tests are based on the spec
Screenshots