test: refactor after PR review

dhis2 · Apr 11, 2024 · d171fee · d171fee
1 parent 9ffab27
commit d171fee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cypress/elements/dimensionModal/dataDimension.js b/cypress/elements/dimensionModal/dataDimension.js
@@ -81,7 +81,7 @@ export const expectDataTypeToBe = (type) =>
     cy.getBySel(dataTypesSelectButtonEl).should('contain', type)
 
 export const expectDataTypeSelectHelpToContain = (text) =>
-    cy.getBySel(dataTypesSelectHelpEl).should('contain', text)
+    cy.getBySel(dataTypesSelectHelpEl).should('have.text', text)
 
 export const expectGroupSelectToNotBeVisible = () =>
     cy.getBySel(groupSelectButtonEl).should('not.exist')

diff --git a/cypress/integration/visTypes/outlierTable.cy.js b/cypress/integration/visTypes/outlierTable.cy.js
@@ -163,7 +163,7 @@ describe(['>=41'], 'using an Outlier table visualization', () => {
         cy.log('has default sorting on Value descending')
         cy.getBySel('outlier-table')
             .findBySel('table-header')
-            .contains('Value')
+            .containsExact('Value')
             .closest('[data-test="table-header"]')
             .find('button')
             .should('have.attr', 'title', 'Sort ascending by Value and update')
@@ -178,14 +178,14 @@ describe(['>=41'], 'using an Outlier table visualization', () => {
 
         cy.getBySel('outlier-table')
             .findBySel('table-header')
-            .contains('Value')
+            .containsExact('Value')
             .closest('[data-test="table-header"]')
             .find('button')
             .should('have.attr', 'title', 'Sort descending by Value and update')
 
         cy.getBySel('outlier-table')
             .findBySel('table-header')
-            .contains('Min')
+            .containsExact('Min')
             .closest('[data-test="table-header"]')
             .find('button')
             .should('have.attr', 'title', 'Sort ascending by Min and update')