fix: fix period filter and loading spinner when filtering in dashboard #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem when a period filter with more than 1 item is applied in dashboard. Passing more than 1 item to the outlier api results in an error.
This happens for example when a filter is added in dashboard which causes the visualization object to change and triggers a re-render of the plugin.
|
🚀 Deployed on https://pr-3002--dhis2-data-visualizer.netlify.app |
2 flaky tests on run #2726 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Event data items correctly |
Test Replay
Screenshots
Video
|
|
| Data dimension > displays Program indicators correctly |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3002 ↗︎
jenniferarnesen
approved these changes
Mar 20, 2024
Merged
dhis2-bot
added a commit
that referenced
this pull request
Mar 21, 2024
## [100.5.1](v100.5.0...v100.5.1) (2024-03-21) ### Bug Fixes * fix period filter and loading spinner when filtering in dashboard ([#3002](#3002)) ([8a54037](8a54037))
|
🎉 This PR is included in version 100.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DHIS2-13858
Key features
Description
When applying filters in dashboard, it's possible to select more than 1 item for the period.
Outlier table only allows for 1 period item.
The fix is to always only use the 1st item for the period dimension, otherwise the outlier api returns an error.
When applying a filter in dashboard, the loading spinner of the plugin didn't trigger.
The fix enabled the loading spinner whenever the plugin props are updated, which causes a re-render of the visualization in the plugin.
Screenshots
Period filter before:
Period filter after:
Loading before:
Loading after:
