fix: fix period filter and loading spinner when filtering in dashboard (

#3002)

* fix: ensure only the first period item is used

This fixes a problem when a period filter with more than 1 item is
applied in dashboard.
Passing more than 1 item to the outlier api results in an error.

* fix: enable the loading spinner when props change

This happens for example when a filter is added in dashboard which
causes the visualization object to change and triggers a re-render of
the plugin.

src/api/analytics.js

@@ -59,7 +59,11 @@ export const getAnalyticsRequestForOutlierTable = ({
     const headers = []
 
     columns.forEach(({ dimension, items }) => {
-        parameters[dimension] = items.map(({ id }) => id).join(',')
+        // only use the first period, this accommodates for the dashboard filter scenario
+        parameters[dimension] =
+            dimension === DIMENSION_ID_PERIOD
+                ? items[0].id
+                : items.map(({ id }) => id).join(',')
 
         headers.push(forDownload ? dimension : dimensionIdHeaderMap[dimension])
 

src/components/VisualizationPlugin/VisualizationPluginWrapper.js

@@ -27,7 +27,10 @@ const VisualizationPluginWrapper = (props) => {
         [pluginProps]
     )
 
-    useEffect(() => setPluginProps(props), [props])
+    useEffect(() => {
+        setIsLoading(true)
+        setPluginProps(props)
+    }, [props])
 
     const onLoadingComplete = () => setIsLoading(false)