Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add classnames and update json instructions file for outlier tables #3000

Merged
merged 9 commits into from
Mar 21, 2024
Merged

fix: add classnames and update json instructions file for outlier tables #3000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c2638f
fix: add classnames and update json instructions file
HendrikThePendric Mar 20, 2024
58cc0e8
fix: correct typo in visualisation type
HendrikThePendric Mar 20, 2024
0575682
fix: change urlReg to urlGlob and correct glob pattern for outlier ta…
HendrikThePendric Mar 20, 2024
7444c91
chore: rename strategy to interceptResponse
HendrikThePendric Mar 20, 2024
6beaefe
Merge branch 'dev' into fix/add-outlier-table-instructions-for-push-a…
jenniferarnesen Mar 21, 2024
de70473
fix: remove query param section from url glob
HendrikThePendric Mar 21, 2024
84b66ed
fix: wait for different SVG for single value
HendrikThePendric Mar 21, 2024
ebd51b8
Merge branch 'fix/add-outlier-table-instructions-for-push-analytics' …
HendrikThePendric Mar 21, 2024
572586b
Merge branch 'dev' into fix/add-outlier-table-instructions-for-push-a…
HendrikThePendric Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 59 additions & 17 deletions public/push-analytics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
{
"version": "0.0.1",
"clearVisualization": {
"strategy": "navigateToUrl",
"steps": [
{ "goto": "{{appUrl}}/#/" },
{ "waitForSelector": ".push-analytics-start-screen" }
]
},
"showVisualization": {
"strategy": "navigateToUrl",
"steps": [
Expand All @@ -11,6 +18,11 @@
"value": "PIVOT_TABLE",
"selector": ".pivot-table-container > table"
},
{
"dashboardItemProperty": "visualization.type",
"value": "OUTLIER_TABLE",
"selector": ".push-analytics-outlier-table"
},
{
"dashboardItemProperty": "visualization.type",
"value": [
Expand All @@ -27,24 +39,52 @@
"YEAR_OVER_YEAR_LINE",
"YEAR_OVER_YEAR_COLUMN",
"SCATTER",
"BUBBLE",
"SINGLE_VALUE",
"PIVOT_TABLE",
"OUTLIER_TABLE"
"BUBBLE"
],
"selector": ".highcharts-container"
"selector": ".highcharts-container > svg"
HendrikThePendric marked this conversation as resolved.
Show resolved Hide resolved
},
{
"dashboardItemProperty": "visualization.type",
"value": "SINGLE_VALUE",
"selector": "[data-test='visualization-container']"
}
]
}
]
},
"triggerDownload": {
"strategy": "useUiElements",
"steps": [
{ "click": ".push-analytics-download-dropdown-menu-button" },
{ "click": ".push-analytics-download-menu-item" }
]
},
"triggerDownloadConditionally": [
{
"dashboardItemProperty": "visualization.type",
"value": [
"COLUMN",
"STACKED_COLUMN",
"BAR",
"STACKED_BAR",
"LINE",
"AREA",
"STACKED_AREA",
"PIE",
"RADAR",
"GAUGE",
"YEAR_OVER_YEAR_LINE",
"YEAR_OVER_YEAR_COLUMN",
"SCATTER",
"BUBBLE",
"SINGLE_VALUE",
"PIVOT_TABLE"
],
"strategy": "useUiElements",
"steps": [
{ "click": ".push-analytics-download-dropdown-menu-button" },
{ "click": ".push-analytics-download-menu-item" }
]
},
{
"dashboardItemProperty": "visualization.type",
"value": "OUTLIER_TABLE",
"strategy": "noop"
}
],
"obtainDownloadArtifactConditionally": [
{
"dashboardItemProperty": "visualization.type",
Expand All @@ -53,6 +93,12 @@
"htmlSelector": "body",
"cssSelector": "style"
},
{
"dashboardItemProperty": "visualization.type",
"value": "OUTLIER_TABLE",
"strategy": "interceptResponse",
"urlGlob": "**/analytics/outlierDetection**"
},
{
"dashboardItemProperty": "visualization.type",
"value": [
Expand All @@ -77,9 +123,5 @@
"strategy": "screenShotImgOnDownloadPage",
"htmlSelector": "img"
}
],
"clearVisualization": {
"strategy": "navigateToUrl",
"steps": [{ "goto": "{{appUrl}}/#/new" }]
}
]
}
5 changes: 4 additions & 1 deletion src/components/Visualization/StartScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ const StartScreen = ({ error, username }) => {
error ? (
getErrorContent()
) : (
<div data-test="start-screen">
<div
data-test="start-screen"
className="push-analytics-start-screen"
>
<div className={styles.section}>
<h3
className={styles.title}
Expand Down
5 changes: 4 additions & 1 deletion src/components/VisualizationPlugin/OutlierTablePlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,10 @@ const OutlierTablePlugin = ({
scrollHeight={getDataTableScrollHeight(isInModal)}
scrollWidth="100%"
width="auto"
className={styles.dataTable}
className={cx(
styles.dataTable,
'push-analytics-outlier-table'
)}
dataTest="outlier-table"
>
<DataTableHead>
Expand Down
Loading