Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add classnames and update json instructions file for outlier tables #3000

Merged

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Mar 20, 2024

Implements DHIS2-17007

Requires dhis2/push-analytics#13


Key features

  1. Adds support for outlier tables in push analytics

Description

  1. Most of the changes in this PR are directly related to the outlier tables
  2. But I have also added a class-name to the start screen so it is clearer for push-analytics to know when the visualization was cleared

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 20, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify March 20, 2024 09:03 Inactive
Copy link

cypress bot commented Mar 20, 2024

2 failed tests on run #2737 ↗︎

2 768 2 0 Flakiness 0

Details:

Merge ebd51b8 into 8a54037...
Project: Data Visualizer App Commit: c06e89cc0c ℹ️
Status: Failed Duration: 07:20 💡
Started: Mar 21, 2024 10:55 AM Ended: Mar 21, 2024 11:03 AM
Failed  cypress/integration/dimensions/data.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > displays Program indicators correctly Test Replay Screenshots Video
Failed  cypress/integration/dimensions/data.cy.js • 1 failed test • e2e-chrome-parallel-2.41

View Output Video

Test Artifacts
Data dimension > displays Event data items correctly Test Replay Screenshots Video

Review all test suite changes for PR #3000 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify March 20, 2024 16:10 Inactive
@HendrikThePendric HendrikThePendric marked this pull request as ready for review March 20, 2024 16:33
"dashboardItemProperty": "visualization.type",
"value": "OUTLIER_TABLE",
"strategy": "interceptResponse",
"urlGlob": "**/analytics/outlierDetection?displayProperty=NAME&**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument might have a different value depending on some settings.
In that case this won't match, perhaps remove the value or the entire query string?

public/push-analytics.json Show resolved Hide resolved
@dhis2-bot dhis2-bot temporarily deployed to netlify March 21, 2024 10:18 Inactive
…of github.com:dhis2/data-visualizer-app into fix/add-outlier-table-instructions-for-push-analytics
@dhis2-bot dhis2-bot temporarily deployed to netlify March 21, 2024 10:25 Inactive
@HendrikThePendric HendrikThePendric changed the title fix: add classnames and update json instructions file fix: add classnames and update json instructions file for outlier tables Mar 21, 2024
@HendrikThePendric HendrikThePendric enabled auto-merge (squash) March 21, 2024 10:30
@dhis2-bot dhis2-bot temporarily deployed to netlify March 21, 2024 11:03 Inactive
@HendrikThePendric HendrikThePendric changed the base branch from dev to master March 21, 2024 11:04
@HendrikThePendric HendrikThePendric merged commit bd95afe into master Mar 21, 2024
23 of 29 checks passed
@HendrikThePendric HendrikThePendric deleted the fix/add-outlier-table-instructions-for-push-analytics branch March 21, 2024 11:45
dhis2-bot added a commit that referenced this pull request Mar 21, 2024
## [100.5.2](v100.5.1...v100.5.2) (2024-03-21)

### Bug Fixes

* add classnames and update json instructions file for outlier tables ([#3000](#3000)) ([bd95afe](bd95afe))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants