Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Outlier table visualization type (DHIS2-13858) #2942

Merged
merged 31 commits into from
Mar 5, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Dec 20, 2023

Implements DHIS2-13858

Requires dhis2/analytics#1598


Key features

  1. implemement a new visualization type for Outliers table

Description

Spec document.


TODO

  • Cypress tests
  • Update docs
  • Manual testing
  • Get final version of info box text and column header tooltips

Known issues

  • issue

Screenshots

Main view:
Screenshot 2024-02-22 at 09 25 10

Data selector only allows for data elements:
Screenshot 2024-02-22 at 09 25 22

Period selector only allows for 1 period:
Screenshot 2024-02-22 at 09 25 30

@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 2 times, most recently from ffa8919 to f1c3448 Compare December 23, 2023 10:50
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from f1c3448 to 7711696 Compare January 4, 2024 14:06
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 4 times, most recently from 33457d0 to a64edf0 Compare January 29, 2024 12:18
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 3 times, most recently from 131a762 to 562195f Compare February 6, 2024 13:29
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 6 times, most recently from 40803f2 to ae4e2de Compare February 27, 2024 14:20
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from ae4e2de to 9e85e34 Compare March 1, 2024 10:06
@edoardo edoardo marked this pull request as ready for review March 1, 2024 14:53
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 9e85e34 to ce717fa Compare March 1, 2024 15:30
edoardo added 3 commits March 5, 2024 10:49
This fixes the issue with the visualization type not changing when using
the View as options in dashboard item context menu.
@dhis2-bot
Copy link
Contributor

@dhis2-bot dhis2-bot temporarily deployed to netlify March 5, 2024 13:17 Inactive
Copy link

cypress bot commented Mar 5, 2024

1 flaky test on run #2680 ↗︎

0 386 1 0 Flakiness 1

Details:

Merge 2db39fe into 77c5bcd...
Project: Data Visualizer App Commit: 5c09930a7e ℹ️
Status: Passed Duration: 06:45 💡
Started: Mar 5, 2024 3:30 PM Ended: Mar 5, 2024 3:36 PM
Flakiness  cypress/integration/dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > displays Program indicators correctly Test Replay Screenshots Video

Review all test suite changes for PR #2942 ↗︎

@edoardo edoardo changed the title feat: outliers table visualization type (DHIS2-13858) feat: support Outlier table visualization type (DHIS2-13858) Mar 5, 2024
@edoardo edoardo merged commit b4a5d53 into dev Mar 5, 2024
31 of 32 checks passed
@edoardo edoardo deleted the feat/outliers-table-DHIS2-13858 branch March 5, 2024 15:44
dhis2-bot added a commit that referenced this pull request Mar 19, 2024
# [100.5.0](v100.4.0...v100.5.0) (2024-03-19)

### Bug Fixes

* **translations:** sync translations from transifex (dev) ([dbb683f](dbb683f))
* fetch displayTitle and displaySubtitle for translations DHIS2-16216 ([#2929](#2929)) ([d6f327a](d6f327a))
* **push-analytics:** add push analytics instructions ([#2985](#2985)) ([77c5bcd](77c5bcd))
* **translations:** sync translations from transifex (dev) ([476e8a8](476e8a8))
* **translations:** sync translations from transifex (dev) ([459c53c](459c53c))
* **translations:** sync translations from transifex (dev) ([2966187](2966187))
* add custom errors for analytics requests ([#2874](#2874)) ([cc3fcd1](cc3fcd1))

### Features

* add class-names for push-analytics ([#2966](#2966)) ([5872a5a](5872a5a))
* support Outlier table visualization type (DHIS2-13858) ([#2942](#2942)) ([e9c31a7](e9c31a7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants