Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Outliers table vis type in DV (DHIS2-13858) #1598

Merged
merged 9 commits into from
Mar 13, 2024
Merged

feat: add support for Outliers table vis type in DV (DHIS2-13858) #1598

merged 9 commits into from
Mar 13, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Dec 20, 2023 •
edited
Loading

Part of the implementation for DHIS2-13858

Relates to dhis2/data-visualizer-app#2942

Key features

  1. add support for the outlierDetection endpoint for aggregate data
  2. add support for the Outlier table visualization type and layout
  3. cleanup of unused code and updated unit tests

Description

This analytics API endpoint is required for the Outliers table visualization type in DV.

TODO

  • update icons for Outlier table visualization type (used in the OpenFileDialog)

@edoardo edoardo mentioned this pull request Dec 20, 2023
Merged
5 tasks
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 3 times, most recently from 9f39c2e to 7b2e0fb Compare January 12, 2024 13:52
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch 2 times, most recently from 4dfa0f8 to 41c5677 Compare January 26, 2024 15:07
@edoardo edoardo mentioned this pull request Feb 16, 2024
Merged
2 tasks
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 41c5677 to 81536d6 Compare February 20, 2024 09:05
@edoardo edoardo mentioned this pull request Feb 20, 2024
Closed
@edoardo edoardo marked this pull request as ready for review March 1, 2024 14:46
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 1af10e3 to 2e0b03d Compare March 1, 2024 15:28
martinkrulltott
martinkrulltott reviewed Mar 4, 2024
View reviewed changes
src/modules/layoutUiRules/index.js
} from './rulesHelper.js'

export {
hasAxisTooManyItemsByVisType as hasAxisTooManyItems,
hasDimensionTooManyItemsByVisType as hasDimensionTooManyItems,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasDimensionTooManyItemsByVisType doesn't sound correct to me. Should be dimensionHasTooManyItemsByVisType? I'm not a native english speaker either though so I'll loop in @jenniferarnesen 🙏

Copy link
Contributor

@martinkrulltott martinkrulltott Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this might just be following the item above called hasAxisTooManyItemsByVisType, but that can't really be used as a reference as it was initially added by me 4 years ago (and I don't understand what I was thinking back then 🙈 ). So that should probably change too..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's following the convention from the line above? It's ugly, yeah, but consistent 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I blame 2019-Martin then 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming all this functions is not really part of the PR's scope.
Should we do it here or in a separate refactor PR?

@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 2e0b03d to 7c8766e Compare March 4, 2024 13:59
martinkrulltott
martinkrulltott reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with comments, see separate topics above

@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 7c8766e to 20adf5b Compare March 5, 2024 12:24
@edoardo edoardo force-pushed the feat/outliers-table-DHIS2-13858 branch from 582633b to 634d2fa Compare March 13, 2024 08:48
@edoardo edoardo merged commit d9b1ccd into master Mar 13, 2024
4 checks passed
@edoardo edoardo deleted the feat/outliers-table-DHIS2-13858 branch March 13, 2024 09:05
dhis2-bot added a commit that referenced this pull request Mar 13, 2024
@dhis2-bot
chore(release): cut 26.5.0 [skip ci]
da7469a 
# [26.5.0](v26.4.1...v26.5.0) (2024-03-13)

### Features

* add support for Outliers table vis type in DV (DHIS2-13858) ([#1598](#1598)) ([d9b1ccd](d9b1ccd))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 26.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferarnesen jenniferarnesen jenniferarnesen left review comments

@martinkrulltott martinkrulltott martinkrulltott approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoardo @dhis2-bot @jenniferarnesen @martinkrulltott