Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow for both 200 and 201 response from backend in cypress tests #2802

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Oct 23, 2023

Needed to keep the cypress tests passing.

There is a recurring issue from the backend: Sometimes a create request returns 200, other times 201. To avoid having to update these tests continually, accept both values as valid since it doesn't have any impact on the app

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 23, 2023

🚀 Deployed on https://pr-2802--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 23, 2023 13:32 Inactive
@jenniferarnesen jenniferarnesen changed the title chore: allow for both 200 and 201 response from backend chore: allow for both 200 and 201 response from backend in cypress tests Oct 23, 2023
@dhis2-bot dhis2-bot temporarily deployed to netlify October 23, 2023 13:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 23, 2023 18:17 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 24, 2023 06:43 Inactive
@jenniferarnesen jenniferarnesen merged commit e62700d into dev Oct 24, 2023
25 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/allow-200-201-created-response branch October 24, 2023 07:49
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants